ci-operator/jobs/openshift/release: Use upgrade-all in chained updates#13002
ci-operator/jobs/openshift/release: Use upgrade-all in chained updates#13002wking wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
wking
force-pushed
the
conformance-post-chained-update
branch
from
f9fddc7 to
f92c233
Compare
|
I've pushed f9fddc76b1 -> f92c233225 to hopefully fix |
|
Hah: $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/13002/rehearse-13002-release-openshift-origin-installer-e2e-aws-upgrade-4.3-to-4.4-to-4.5-to-4.6-ci/1319006396699643904/artifacts/e2e-aws-upgrade-all/clusterversion.json | jq -r '.items[].status.history[] | .startedTime + " " + .completionTime + " " + .version + " " + .state + " " + (.verified | tostring) + " " + .image'
2020-10-21T20:44:16Z Partial false RELEASE_IMAGES
2020-10-21T20:22:31Z 2020-10-21T20:40:46Z 4.3.40 Completed false quay.io/openshift-release-dev/ocp-release@sha256:9ff90174a170379e90a9ead6e0d8cf6f439004191f80762764a5ca3dbaab01dcI'm just cribbing the |
wking
force-pushed
the
conformance-post-chained-update
branch
from
f92c233 to
9dbc178
Compare
wking
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Using the 'upgrade-all' precedent from cfcd60f (release: Standardize all ci-chat-bot jobs, 2020-04-27, openshift#8594). I'm not clear on why we are joining with a newline instead of '&&'; presumably this is getting wrapped in a 'set -e' or equivalent. But I'm sticking with newline to match precedent. This increases the risk that we time out these slow jobs (e.g. [1] took 3h42m), but we really want to exercise tests like openshift/origin@9f7fe0089d (Add test for scaling machineSets, 2019-04-11, openshift/origin#22564), which is in openshift/conformance/serial, because machines launch with the born-in boot images until we get [2]. And in fact, the reason why we didn't have this post-update suite in 4.6 was because of 3bc9d8e (stop running e2e tests after three upgrades because we hit timeouts and lose upgrade signal, 2020-10-05, openshift#12436). But since 3c915e2 (ci-operator/step-registry/openshift/e2e/test: Add 2h active_deadline_seconds, 2020-10-09, openshift#12647), we no longer have to worry about getting logs when that step is slow. So we might not pass if we're slow, but we'll still get logs to debug why we're slow. Only for 4.6 and later, because 4.5 is live and if we had problems there we'd probably have already heard about them from customers. [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade-4.3-to-4.4-to-4.5-to-4.6-ci/1318709056830967808 [2]: openshift/enhancements#201
wking
force-pushed
the
conformance-post-chained-update
branch
from
9dbc178 to
9ed2193
Compare
|
No longer a WIP, because I'm bumping 4.7 now too. No 4.8 yet, so nothing to bump beyond 4.7. CC @deads2k , since this is something of a revert for #12436. In fact, because I want the |
openshift-ci-robot
added
the
do-not-merge/hold
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci-robot
added
the
lifecycle/stale
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci-robot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
WIP because I'm only messing with 4.6 for now. If presubmits look good, I'll expand to the other versions.
Using the
upgrade-allprecedent from cfcd60f (#8594). I'm not clear on why we are joining with;instead of&&; presumably this is getting wrapped in aset -eor equivalent. But I'm sticking with;to match precedent.This increases the risk that we time out these slow jobs (e.g. this job took 3h42m), but we really want to exercise tests like openshift/origin@9f7fe0089d (openshift/origin#22564), which is in
openshift/conformance/serial, because machines launch with the born-in boot images until we get openshift/enhancements#201.