Skip to content

Add ceph storage plugin tests for for openshift/console #14682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 29, 2021
Merged

Add ceph storage plugin tests for for openshift/console #14682

openshift-merge-robot merged 1 commit into from
Jan 29, 2021

Conversation

@bipuladh
Copy link
Contributor

@bipuladh bipuladh commented Jan 7, 2021

  • Adds tests that are run conditionally if Ceph code is touched.

@bipuladh bipuladh mentioned this pull request Jan 7, 2021
Closed
@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 7, 2021

/retest

2 similar comments
@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 8, 2021

/retest

@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 8, 2021

/retest

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jan 8, 2021

@bipuladh: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/pj-rehearse 40a703876b4e1a2739d313eb6b5d01b64afcf01f link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 15, 2021

/retest

5 similar comments
@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 15, 2021

/retest

@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 16, 2021

/retest

@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 17, 2021

/retest

@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 18, 2021

/retest

@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 18, 2021

/retest

@droslean
Copy link
Member

droslean commented Jan 18, 2021

/test pj-rehearse

@bipuladh bipuladh force-pushed the ceph-tests branch 2 times, most recently from 2898817 to 4fe702a Compare January 18, 2021 17:07
@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 18, 2021

/test pj-rehearse

@droslean
Copy link
Member

droslean commented Jan 19, 2021

/test pj-rehearse

droslean
droslean reviewed Jan 19, 2021
View reviewed changes
@bipuladh bipuladh force-pushed the ceph-tests branch 3 times, most recently from 7dfd4e4 to 752e6c7 Compare January 19, 2021 17:28
@droslean
Copy link
Member

droslean commented Jan 22, 2021

/test pj-rehearse

@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 27, 2021

/retest

2 similar comments
@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 27, 2021

/retest

@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 27, 2021

/retest

@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 28, 2021

/retest

3 similar comments
@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 29, 2021

/retest

@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 29, 2021

/retest

@bipuladh
Copy link
Contributor Author

bipuladh commented Jan 29, 2021

/retest

spadgett
spadgett approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit 103aa95 into openshift:master Jan 29, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 29, 2021

@bipuladh: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-console-master.yaml using file ci-operator/config/openshift/console/openshift-console-master.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-console-master-presubmits.yaml using file ci-operator/jobs/openshift/console/openshift-console-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-console-master-presubmits.yaml using file ci-operator/jobs/openshift/console/openshift-console-master-presubmits.yaml
Details

In response to this:

  • Adds tests that are run conditionally if Ceph code is touched.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

spadgett commented Jan 29, 2021

@bipuladh It looks like this is causing failures on all PRs. I'm going to revert.

https://prow.ci.openshift.org/?repo=openshift%2Fconsole&job=pull-ci-openshift-console-master-ceph-storage-plugin

@spadgett spadgett mentioned this pull request Jan 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@jhadvig jhadvig Awaiting requested review from jhadvig

2 more reviewers

@droslean droslean droslean left review comments

@spadgett spadgett spadgett approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bipuladh @openshift-merge-robot @droslean @openshift-ci-robot @spadgett