Skip to content

Add ceph storage gating configuration for openshift/console #13744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
a2batic wants to merge 1 commit into from
Closed

Add ceph storage gating configuration for openshift/console #13744

a2batic wants to merge 1 commit into from

Conversation

@a2batic
Copy link

@a2batic a2batic commented Nov 19, 2020

Signed-off-by: Kanika Murarka kmurarka@redhat.com

@a2batic
Copy link
Author

a2batic commented Nov 20, 2020

/test pj-rehearse

1 similar comment
@bipuladh
Copy link
Contributor

bipuladh commented Nov 23, 2020

/test pj-rehearse

@a2batic
Copy link
Author

a2batic commented Nov 24, 2020

/assign @rhrazdil

@bipuladh
Copy link
Contributor

bipuladh commented Nov 24, 2020

/test pj-rehearse

@a2batic a2batic force-pushed the ceph-e2e branch 3 times, most recently from 319b638 to a66a29e Compare November 24, 2020 07:33
@a2batic
Copy link
Author

a2batic commented Nov 24, 2020

/assign @AlexNPavel

cloudbehl
cloudbehl reviewed Nov 24, 2020
View reviewed changes
ci-operator/jobs/openshift/console/openshift-console-master-presubmits.yaml Outdated
Copy link

@cloudbehl cloudbehl Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value: ./test-cypress.sh -p ceph -h true
value: ./test-prow-e2e.sh ceph

Copy link

@cloudbehl cloudbehl Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openshift/console#7308

@bipuladh
Copy link
Contributor

bipuladh commented Nov 24, 2020

/hold
until openshift/console#7308 merges

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2020
@cloudbehl
Copy link

cloudbehl commented Nov 24, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2020
@cloudbehl
Copy link

cloudbehl commented Nov 26, 2020

/retest

@cloudbehl
Copy link

cloudbehl commented Nov 26, 2020

/test pj-rehearse

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2020
@a2batic
Copy link
Author

a2batic commented Nov 27, 2020

/test pj-rehearse

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2020
@cloudbehl
Copy link

cloudbehl commented Dec 16, 2020

@a2batic can you rebase the PR and also add a new parameter of instance_type.

#14350

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2020
cloudbehl
cloudbehl reviewed Dec 17, 2020
View reviewed changes
ci-operator/jobs/openshift/console/openshift-console-master-presubmits.yaml Outdated
Copy link

@cloudbehl cloudbehl Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add this?

    - name: COMPUTE_NODE_TYPE
      value: m5.2xlarge

Copy link
Contributor

@bipuladh bipuladh Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: m4.2xlarge

umangachapagain
umangachapagain suggested changes Dec 17, 2020
View reviewed changes
ci-operator/config/openshift/console/openshift-console-master.yaml Outdated
Copy link
Contributor

@umangachapagain umangachapagain Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cluster_profile: azure4
cluster_profile: aws

core-services/template-deprecation/_allowlist.yaml Outdated
Comment on lines 199 to 201
Copy link
Contributor

@umangachapagain umangachapagain Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pull-ci-openshift-console-master-ceph-storage-plugin:
generated: true
kind: presubmit

Add ceph storage gating configuration for openshift/console
93f0974 
Signed-off-by: Kanika Murarka <kmurarka@redhat.com>
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: a2batic
To complete the pull request process, please assign alexnpavel after the PR has been reviewed.
You can assign the PR to them by writing /assign @alexnpavel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bipuladh
Copy link
Contributor

bipuladh commented Dec 17, 2020

/retest

5 similar comments
@bipuladh
Copy link
Contributor

bipuladh commented Dec 28, 2020

/retest

@bipuladh
Copy link
Contributor

bipuladh commented Dec 29, 2020

/retest

@bipuladh
Copy link
Contributor

bipuladh commented Dec 29, 2020

/retest

@bipuladh
Copy link
Contributor

bipuladh commented Dec 30, 2020

/retest

@cloudbehl
Copy link

cloudbehl commented Jan 4, 2021

/retest

@cloudbehl
Copy link

cloudbehl commented Jan 4, 2021

test pj-rehearse

@bipuladh
Copy link
Contributor

bipuladh commented Jan 5, 2021

/retest

1 similar comment
@bipuladh
Copy link
Contributor

bipuladh commented Jan 5, 2021

/retest

@bipuladh
Copy link
Contributor

bipuladh commented Jan 5, 2021

/retest ci/prow/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 5, 2021

@bipuladh: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build01-dry
  • /test build02-dry
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-testgrid-allow-list
  • /test config
  • /test core-dry
  • /test core-valid
  • /test correctly-sharded-config
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test ordered-prow-config
  • /test owners
  • /test pj-rehearse
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-dry
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test vsphere-dry
  • /test pylint
  • /test yamllint

Use /test all to run the following jobs:

  • pull-ci-openshift-release-master-app-ci-config-dry
  • pull-ci-openshift-release-master-boskos-config
  • pull-ci-openshift-release-master-boskos-config-generation
  • pull-ci-openshift-release-master-build01-dry
  • pull-ci-openshift-release-master-build02-dry
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-config-metadata
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-config
  • pull-ci-openshift-release-master-core-dry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-generated-config
  • pull-ci-openshift-release-master-generated-dashboards
  • pull-ci-openshift-release-master-ordered-prow-config
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-pj-rehearse
  • pull-ci-openshift-release-master-prow-config
  • pull-ci-openshift-release-master-prow-config-filenames
  • pull-ci-openshift-release-master-prow-config-semantics
  • pull-ci-openshift-release-master-release-config
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-master-secret-generator-config-valid
  • pull-ci-openshift-release-master-services-dry
  • pull-ci-openshift-release-master-services-valid
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-master-vsphere-dry
  • pull-ci-openshift-release-yamllint
Details

In response to this:

/retest ci/prow/pj-rehearse

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh
Copy link
Contributor

bipuladh commented Jan 5, 2021

/retest

2 similar comments
@bipuladh
Copy link
Contributor

bipuladh commented Jan 6, 2021

/retest

@bipuladh
Copy link
Contributor

bipuladh commented Jan 7, 2021

/retest

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jan 7, 2021

@a2batic: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/console/master/ceph-storage-plugin 93f0974 link /test pj-rehearse
ci/prow/pj-rehearse 93f0974 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2021

@a2batic: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/pj-rehearse 93f0974 link /test pj-rehearse
ci/rehearse/openshift/console/master/ceph-storage-plugin 93f0974 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bipuladh
Copy link
Contributor

bipuladh commented Jan 7, 2021

/close
Replacement PR: #14682

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 7, 2021

@bipuladh: Closed this PR.

Details

In response to this:

/close
Replacement PR: #14682

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@rhamilto rhamilto Awaiting requested review from rhamilto

3 more reviewers

@cloudbehl cloudbehl cloudbehl left review comments

@bipuladh bipuladh bipuladh left review comments

@umangachapagain umangachapagain umangachapagain requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AlexNPavel AlexNPavel

@umangachapagain umangachapagain

@rhrazdil rhrazdil

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@a2batic @bipuladh @cloudbehl @openshift-ci-robot @openshift-merge-robot @umangachapagain @AlexNPavel @rhrazdil