Update OKD after master moved to 4.8#15802
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Feb 19, 2021
Merged
Update OKD after master moved to 4.8#15802openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
Contributor
Author
|
/cc @gabemontero |
openshift-ci-robot
requested review from
gabemontero,
kevinrizza,
sinnykumari and
smarterclayton
gabemontero
reviewed
Feb 11, 2021
Contributor
gabemontero
left a comment
gabemontero
left a comment
There was a problem hiding this comment.
on possible need for update
Contributor
There was a problem hiding this comment.
should this not be 4.8
that would be consistent with https://github.com/openshift/release/blob/master/ci-operator/config/openshift/cluster-samples-operator/openshift-cluster-samples-operator-release-4.7__okd.yaml
and the master file below
vrutkovs
force-pushed
the
okd-4.8-master
branch
3 times, most recently
from
2c649ba to
13bc236
Compare
Contributor
Author
|
/retest |
sinnykumari
reviewed
Feb 15, 2021
Contributor
There was a problem hiding this comment.
'optional: true` is missing for the jobs
Contributor
Author
There was a problem hiding this comment.
Updated:
- https://github.com/openshift/release/pull/15802/files#diff-38238cb6f4ec8238b5e94af12df0ddac3ca1d17cb88e5a1d80c00c0a467c927fR1329
- https://github.com/openshift/release/pull/15802/files#diff-38238cb6f4ec8238b5e94af12df0ddac3ca1d17cb88e5a1d80c00c0a467c927fR1399
- https://github.com/openshift/release/pull/15802/files#diff-38238cb6f4ec8238b5e94af12df0ddac3ca1d17cb88e5a1d80c00c0a467c927fR1471
- https://github.com/openshift/release/pull/15802/files#diff-38238cb6f4ec8238b5e94af12df0ddac3ca1d17cb88e5a1d80c00c0a467c927fR1543
vrutkovs
force-pushed
the
okd-4.8-master
branch
from
13bc236 to
2ab7b53
Compare
Contributor
|
LGTM |
Contributor
|
/approve |
vrutkovs
force-pushed
the
okd-4.8-master
branch
from
2ab7b53 to
8b814ee
Compare
Contributor
|
/approve but ooo until tomorrow so can’t review |
openshift-ci-robot
added
the
approved
LorbusChris
reviewed
Feb 15, 2021
Contributor
Author
There was a problem hiding this comment.
I'm using the same tags as in openshift-cluster-samples-operator-release-4.8.yaml here
LorbusChris
reviewed
Feb 16, 2021
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
ah, good catch, updated
vrutkovs
force-pushed
the
okd-4.8-master
branch
2 times, most recently
from
73373fd to
e86dd60
Compare
vrutkovs
force-pushed
the
okd-4.8-master
branch
from
e86dd60 to
864ae41
Compare
Contributor
|
/lgtm |
Contributor
|
/hold if you want to see whether these rehearse |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero, smarterclayton, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
Author
|
4.8 failures are odd (bootstrap broken?), we'll figure those out one by one /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
|
@vrutkovs: Updated the following 13 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates custom configuration for OKD components.