openshift-machine-config-operator: remove autopromotion to origin

[vrutkovs]

MCO needs time to accommodate for FCOS changes, so we'll disable the autopromotion to 4.6/4.7 for now.

OKD team will manually promote MCO images after verification, no further actions required from MCO team.

[vrutkovs]

/cc @darkmuggle

[openshift-ci]

@vrutkovs: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/machine-config-operator/release-4.6/okd-e2e-vsphere	8fae300	link	/test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.6/okd-e2e-upgrade	8fae300	link	/test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.6/okd-e2e-gcp-op	8fae300	link	/test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.6/okd-e2e-aws	8fae300	link	/test pj-rehearse
ci/prow/pj-rehearse	8fae300	link	/test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/okd-e2e-upgrade	8fae300	link	/test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/okd-e2e-aws	8fae300	link	/test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/okd-e2e-gcp-op	8fae300	link	/test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/okd-e2e-vsphere	8fae300	link	/test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[darkmuggle]

/hold

Won't the effect of this require the MCO to manually promote OKD? What's the desired outcome of this PR? I fear that removing the MCO from automatic promotions will result in nothing being promoted.

[darkmuggle]

/cc @crawford @ashcrow

[ashcrow]

@vrutkovs What FCOS changes are being referenced here?

[vrutkovs]

Won't the effect of this require the MCO to manually promote OKD?

Yes.

What's the desired outcome of this PR? I fear that removing the MCO from automatic promotions will result in nothing being promoted.

That gives us time to verify that MCO changes haven't impacted OKD. That certainly would be slower, but should provide a better quality for OKD releases.

What FCOS changes are being referenced here?

In FCOS Ignition places ssh keys in ~/.ssh/authorized_keys.d/ignition, but MCO controls ~/.ssh/authorized_keys. This makes it fail on FCOS - and RHCOS is configured to run Ignition with (legacy?) ssh key merging

[darkmuggle]

That gives us time to verify that MCO changes haven't impacted OKD. That certainly would be slower, but should provide a better quality for OKD releases.

Who would promote the MCO, then? I want to be really clear about the expectations and have them clearly set. The MCO team is not staffed to take on manual promotion and validation for OKD.

[vrutkovs]

Who would promote the MCO, then?

OKD team would

The MCO team is not staffed to take on manual promotion and validation for OKD.

MCO team has approved promotion for release-4.6/release-4.7/master commits to OKD in #12683, it also adds (optional) OKD tests. If MCO is unwilling to include these results when making a decision to merge a PR OKD team will take care of verifying MCO changes landing in OKD. No action from MCO needed, and this change won't affect promotion to OCP

[darkmuggle]

This sounds reasonable to me then.
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darkmuggle, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/machine-config-operator/OWNERS [darkmuggle]
• ci-operator/jobs/openshift/machine-config-operator/OWNERS [darkmuggle]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrutkovs]

Included in #15802