Skip to content

osa: add daily job that tests production deployments#1948

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
0xmichalis:prod-testing
Oct 18, 2018
Merged

osa: add daily job that tests production deployments#1948
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
0xmichalis:prod-testing

Conversation

@0xmichalis
Copy link
Copy Markdown
Contributor

@0xmichalis 0xmichalis commented Oct 17, 2018

@openshift/sig-azure this PR adds a daily job in CI that runs cluster deployments via the e2e RP framework using the production RP.

@openshift-ci-robot openshift-ci-robot added the sig/azure Categorizes item related to Azure jobs label Oct 17, 2018
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2018
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kargakis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2018
@0xmichalis
Copy link
Copy Markdown
Contributor Author

0xmichalis commented Oct 17, 2018

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2018
@0xmichalis
Copy link
Copy Markdown
Contributor Author

0xmichalis commented Oct 17, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2018
0xmichalis
0xmichalis commented Oct 17, 2018
View reviewed changes
Comment thread ci-operator/jobs/openshift/openshift-azure/openshift-openshift-azure-periodics.yaml
containers:
- args:
- --secret-dir=/usr/local/e2e-secrets/azure
- --target=[output:stable:sync]
Copy link
Copy Markdown
Contributor Author

@0xmichalis 0xmichalis Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really needed; I will see whether we can get rid of it w/o needing any changes in the template in a follow-up.

@0xmichalis
Copy link
Copy Markdown
Contributor Author

0xmichalis commented Oct 17, 2018

We are using master to run the e2e tests atm. We probably want to match with the commit that is run in prod (so I guess we should be using the private preview branch?).

@0xmichalis
Copy link
Copy Markdown
Contributor Author

0xmichalis commented Oct 17, 2018

/cc charlesakalugwu

@kwoodson
Copy link
Copy Markdown

kwoodson commented Oct 17, 2018

@Kargakis

We are using master to run the e2e tests atm. We probably want to match with the commit that is run in prod (so I guess we should be using the private preview branch?).

Using a commit ID, tag, or branch makes sense to me.

@0xmichalis
Copy link
Copy Markdown
Contributor Author

0xmichalis commented Oct 18, 2018

Unfortunately we cannot use the private preview branch because we would have to backport all the e2e framework machinery to it. For now, we should be fine with master I think. Will try this out and see how it works.

@0xmichalis 0xmichalis added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2018
@openshift-merge-robot openshift-merge-robot merged commit 7586db1 into openshift:master Oct 18, 2018
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 18, 2018

@Kargakis: Updated the following 2 configmaps:

  • prow-job-cluster-launch-e2e-azure configmap using the following files:
    • key cluster-launch-e2e-azure.yaml using file ci-operator/templates/openshift/openshift-azure/cluster-launch-e2e-azure.yaml
  • job-config configmap using the following files:
    • key openshift-openshift-azure-periodics.yaml using file ci-operator/jobs/openshift/openshift-azure/openshift-openshift-azure-periodics.yaml
Details

In response to this:

@openshift/sig-azure this PR adds a daily job in CI that runs cluster deployments via the e2e RP framework using the production RP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0xmichalis 0xmichalis deleted the prod-testing branch October 18, 2018 07:02
@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Jan 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jim-minter jim-minter Awaiting requested review from jim-minter

@kwoodson kwoodson Awaiting requested review from kwoodson

@charlesakalugwu charlesakalugwu Awaiting requested review from charlesakalugwu

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/azure Categorizes item related to Azure jobs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0xmichalis @openshift-ci-robot @kwoodson @openshift-merge-robot