ovirt: Add machine-config-operator presubmit#6533
ovirt: Add machine-config-operator presubmit#6533openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
|
waiting for #4340 to merge. looks fine otherwise. /hold |
|
On Mon, 6 Jan 2020 at 20:32, Kirsten ***@***.***> wrote:
waiting for #4340 <#4340> to
merge. looks fine otherwise.
It is other way round, this PR is necessary for #4340 to be green to merge.
/hold
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6533?email_source=notifications&email_token=ABGBYHBFNEHE22P6K64WFWLQ4N2MBA5CNFSM4KBVQEH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIGKSHY#issuecomment-571255071>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGBYHGHY6YUISE36PUQYP3Q4N2MBANCNFSM4KBVQEHQ>
.
|
|
wait.. now im confused... is it post holiday haze? :) This PR is adding ovirt tests to MCO right? But AFAICT openshift/installer#1948 which is what adds ovirt to installer isn't merged yet no? So wouldn't this PR depend on #1948? We can't run any tests until installer can install ovirt... no? Looking closely, not sure why installer e2e would depend on mco e2e (via #4340 ) Can you clarify so I understand? |
|
You are 100% right, I was confusing this with other mao PR. This is my
evening haze :)
…On Tue, 7 Jan 2020 at 02:00, Kirsten ***@***.***> wrote:
wait.. now im confused... is it post holiday haze? :)
This PR is adding ovirt tests to MCO right? But AFAICT
openshift/installer#1948
<openshift/installer#1948> which is what adds
ovirt to installer isn't merged yet no?
So wouldn't this PR depend on #1948
<#1948>? We can't run any tests
until installer can install ovirt... no?
Looking closely, not sure why installer e2e would depend on mco e2e (via
#4340 <#4340> )
Can you clarify so I understand?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6533?email_source=notifications&email_token=ABGBYHG4F6HG6H2GFCHWUHLQ4PA2RA5CNFSM4KBVQEH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHGK3Y#issuecomment-571368815>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGBYHBAIEL7Y3NDNHVD6JTQ4PA2RANCNFSM4KBVQEHQ>
.
|
|
/retest |
|
@kikisdeliveryservice #4340 is merged |
357d7aa to
4b84ffc
Compare
Signed-off-by: Roy Golan <rgolan@redhat.com>
4b84ffc to
79ef034
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rgolangh, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold cancel |
|
@rgolangh: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Depends-on: #4340