Skip to content

ovirt: Add machine-config-operator presubmit#6533

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
rgolangh:ovirt-e2e-mco
Jan 23, 2020
Merged

ovirt: Add machine-config-operator presubmit#6533
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
rgolangh:ovirt-e2e-mco

Conversation

@rgolangh
Copy link
Copy Markdown
Contributor

Depends-on: #4340

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 31, 2019
@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

waiting for #4340 to merge. looks fine otherwise.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2020
@rgolangh
Copy link
Copy Markdown
Contributor Author

rgolangh commented Jan 6, 2020 via email

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

wait.. now im confused... is it post holiday haze? :)

This PR is adding ovirt tests to MCO right? But AFAICT openshift/installer#1948 which is what adds ovirt to installer isn't merged yet no?

So wouldn't this PR depend on #1948? We can't run any tests until installer can install ovirt... no?

Looking closely, not sure why installer e2e would depend on mco e2e (via #4340 )

Can you clarify so I understand?

@rgolangh
Copy link
Copy Markdown
Contributor Author

rgolangh commented Jan 7, 2020 via email

@rgolangh
Copy link
Copy Markdown
Contributor Author

/retest

@rgolangh
Copy link
Copy Markdown
Contributor Author

@kikisdeliveryservice #4340 is merged

Signed-off-by: Roy Golan <rgolan@redhat.com>
@runcom
Copy link
Copy Markdown
Member

runcom commented Jan 23, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rgolangh, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020
@rgolangh
Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2020
@openshift-merge-robot openshift-merge-robot merged commit c81fc1b into openshift:master Jan 23, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rgolangh: Updated the job-config-master configmap in namespace ci at cluster default using the following files:

  • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
Details

In response to this:

Depends-on: #4340

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants