-
Notifications
You must be signed in to change notification settings - Fork 2.1k
ci-operator/step-registry/ipi/conf: Move PATCH from SHARED_DIR to /tmp #20865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We've been copy/pasting the SHARED_DIR approach around since f249775 (steps: add shared network, 2020-06-05, openshift#9517). But while later steps will need the patched file, they won't need the patch itself. Move the patch into /tmp to save some space and reduce clutter in the shared directory. Generated with: $ sed -i 's|PATCH="${SHARED_DIR}/\([^"]*\)"|PATCH=/tmp/\1|' $(git grep -l 'PATCH=.*SHARED_DIR' ci-operator/step-registry)
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
vrutkovs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrutkovs, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@wking: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We've been copy/pasting the
SHARED_DIRapproach around since f249775 (#9517). But while later steps will need the patched file, they won't need the patch itself. Move the patch into/tmpto save some space and reduce clutter in the shared directory.Generated with:
$ sed -i 's|PATCH="${SHARED_DIR}/\([^"]*\)"|PATCH=/tmp/\1|' $(git grep -l 'PATCH=.*SHARED_DIR' ci-operator/step-registry)