installer: use steps for e2e-{aws,azure,gcp}-shared-vpc #9517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
abhinavdahiya
force-pushed
the
shared-network
branch
from
f96d892 to
a7910bf
Compare
abhinavdahiya
changed the title
abhinavdahiya
force-pushed
the
shared-network
branch
from
a920474 to
8ef94c6
Compare
Contributor
Author
|
/retest |
wking
reviewed
Jun 9, 2020
| @@ -0,0 +1,11 @@ | |||
| approvers: | |||
Member
There was a problem hiding this comment.
should probably include @jstuever and @patrickdillon based on installer AWS approvers. And possibly some folks in your current list aren't interested in being approvers for this specific directory (folks with a general interest in multi-step are probably already approvers from root-wards directories and don't need to be repeated down in this one).
Contributor
Author
There was a problem hiding this comment.
The CI test requires adding OWNERS to each new dir, so i just copied the parent dir owners to this. If we need to change any we should update them in one go. I'm just ensuring the same ownership continues to each child.
Contributor
Author
|
/retest |
wking
reviewed
Jun 9, 2020
| set -o pipefail | ||
|
|
||
| # TODO: move to image | ||
| curl -L https://github.com/mikefarah/yq/releases/download/3.3.0/yq_linux_amd64 -o /tmp/yq && chmod +x /tmp/yq |
Member
There was a problem hiding this comment.
Don't we have an image that contains yq now? Alternative would be to have an image that contains jq and write the install-config in JSON.
Contributor
Author
There was a problem hiding this comment.
we don't have such a image, so for now this should work.
i need to find a good place to install the yq binary.
as for installer and json is not happening any time soon so that doesn't help here.
this should be stable enough to fix in future work.
Member
There was a problem hiding this comment.
as for installer and json is not happening any time soon so that doesn't help here.
JSON is a subset of YAML, so the installer will be fine ingesting either.
Looks like openshift/origin#22378 putting jq in test rotted out. But sure, I guess we can curl down unsigned binaries in the short term :p.
wking
reviewed
Jun 9, 2020
| @@ -0,0 +1,10 @@ | |||
| ref: | |||
| as: ipi-conf-aws-sharednetwork | |||
Member
There was a problem hiding this comment.
We do this in a few places already, but I hear there are some ci-tools issues with using the same name for both a ref and a chain. Might be worth using different names for them here; or maybe that's no longer an issue.
Contributor
There was a problem hiding this comment.
wking
reviewed
Jun 9, 2020
| @@ -0,0 +1,2 @@ | |||
| approvers: | |||
| - abhinavdahiya | |||
Member
There was a problem hiding this comment.
Can we extend this to include @fabianofranz and @jhixson74 ? Having a single approver seems like a risk for over-silo'ed understanding (although root-ward approvers are also theoretically on the hook to provide maintenance in this subdir as well).
Member
There was a problem hiding this comment.
Out of band, @abhinavdahiya wants to punt on this too, like here.
Member
|
GCP rehearsal failed on install. AWS rehearsal is strange: But there are no logs from that conf container. Kick them again to see what they do this time: /retest |
Member
|
GCP: Dunno what that's about. |
Member
Contributor
Author
|
/test pj-rehearse |
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@abhinavdahiya: Updated the following 5 configmaps:
DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Aug 3, 2021
We've been copy/pasting the SHARED_DIR approach around since f249775 (steps: add shared network, 2020-06-05, openshift#9517). But while later steps will need the patched file, they won't need the patch itself. Move the patch into /tmp to save some space and reduce clutter in the shared directory. Generated with: $ sed -i 's|PATCH="${SHARED_DIR}/\([^"]*\)"|PATCH=/tmp/\1|' $(git grep -l 'PATCH=.*SHARED_DIR' ci-operator/step-registry)
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Aug 3, 2021
…o, PATCH
It's extremely unlikely that there is any content in the target
${PATCH} location before each step writes its specific content. But
just in case, and to help folks reading the code avoid wondering about
it, write the file with '>', instead of appending with '>>'. This
adjusts a pattern we've been following since f249775 (steps: add
shared network, 2020-06-05, openshift#9517).
Generated with:
$ sed -i 's/ >> \("${PATCH}"\)/ > \1/' $(git grep -l '>>.*PATCH' ci-operator/step-registry)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.