Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Aug 3, 2021

It's extremely unlikely that there is any content in the target ${PATCH} location before each step writes its specific content. But just in case, and to help folks reading the code avoid wondering about it, write the file with >, instead of appending with >>. This adjusts a pattern we've been following since f249775 (#9517).

Generated with:

$ sed -i 's/ >> \("${PATCH}"\)/ > \1/' $(git grep -l '>>.*PATCH' ci-operator/step-registry)

…o, PATCH

It's extremely unlikely that there is any content in the target
${PATCH} location before each step writes its specific content.  But
just in case, and to help folks reading the code avoid wondering about
it, write the file with '>', instead of appending with '>>'.  This
adjusts a pattern we've been following since f249775 (steps: add
shared network, 2020-06-05, openshift#9517).

Generated with:

  $ sed -i 's/ >> \("${PATCH}"\)/ > \1/' $(git grep -l '>>.*PATCH' ci-operator/step-registry)
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/release-4.9/e2e-aws-shared-vpc 957e309 link /test pj-rehearse
ci/rehearse/openshift/cloud-credential-operator/release-4.9/e2e-aws-manual-oidc 957e309 link /test pj-rehearse
ci/rehearse/openshift/installer/release-4.9/e2e-gcp-shared-vpc 957e309 link /test pj-rehearse
ci/prow/pj-rehearse 957e309 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@e-tienne e-tienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: e-tienne, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 15a5a1c into openshift:master Aug 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

@wking: Updated the step-registry configmap in namespace ci at cluster app.ci using the following files:

  • key ipi-conf-aws-blackholenetwork-commands.sh using file ci-operator/step-registry/ipi/conf/aws/blackholenetwork/ipi-conf-aws-blackholenetwork-commands.sh
  • key ipi-conf-aws-sharednetwork-commands.sh using file ci-operator/step-registry/ipi/conf/aws/sharednetwork/ipi-conf-aws-sharednetwork-commands.sh
  • key ipi-conf-azure-resourcegroup-commands.sh using file ci-operator/step-registry/ipi/conf/azure/resourcegroup/ipi-conf-azure-resourcegroup-commands.sh
  • key ipi-conf-azure-sharednetwork-commands.sh using file ci-operator/step-registry/ipi/conf/azure/sharednetwork/ipi-conf-azure-sharednetwork-commands.sh
  • key ipi-conf-gcp-sharednetwork-commands.sh using file ci-operator/step-registry/ipi/conf/gcp/sharednetwork/ipi-conf-gcp-sharednetwork-commands.sh
  • key ipi-conf-manual-creds-commands.sh using file ci-operator/step-registry/ipi/conf/manual-creds/ipi-conf-manual-creds-commands.sh
Details

In response to this:

It's extremely unlikely that there is any content in the target ${PATCH} location before each step writes its specific content. But just in case, and to help folks reading the code avoid wondering about it, write the file with >, instead of appending with >>. This adjusts a pattern we've been following since f249775 (#9517).

Generated with:

$ sed -i 's/ >> \("${PATCH}"\)/ > \1/' $(git grep -l '>>.*PATCH' ci-operator/step-registry)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the overwrite-instead-of-appending-to-patches branch August 4, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants