e2e: Prepare to support new openshift-tests binary in 4.0 jobs#2108
e2e: Prepare to support new openshift-tests binary in 4.0 jobs#2108openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
smarterclayton
force-pushed
the
launch_aws
branch
from
3dd1580 to
677f311
Compare
There was a problem hiding this comment.
Is this just while you're testing? Won't we want the function and script to return the openshift-tests exit status?
There was a problem hiding this comment.
it should already be set -e
There was a problem hiding this comment.
it should already be set -e
Oh, right. exit 0 is fine then, although I'd prefer a bare exit to avoid confusing folks like me who forget about the set -e ;).
There was a problem hiding this comment.
the rest of the function avoids bare exits to be clear. In the long run, this would simply be a call to Openshift-tests, but until we remove the other sections it's better to be consistent.
There was a problem hiding this comment.
Do we need to sleep? If we just want to exercise the setup and teardown containers, couldn't this command just be exit 0?
There was a problem hiding this comment.
the point of launch is to hold the cluster open so you can use it, that's why it's sleeping
There was a problem hiding this comment.
basically you run /test launch-aws and then you have a cluster you can use for X minutes.
There was a problem hiding this comment.
basically you run /test launch-aws and then you have a cluster you can use for X minutes.
Ah, this makes sense. Can we put a comment about that into the commit message in case I don't remember later? A comment in the YAML would be fine too, but we sometimes mechanically rewrite YAML and dump any comments ;).
There was a problem hiding this comment.
Yeah, launch is a fairly general convention we have. It'll be part of the general CI docs.
smarterclayton
force-pushed
the
launch_aws
branch
3 times, most recently
from
f22f078 to
d2963da
Compare
The new binary is simpler and easier to reason about. Also add a `launch-aws` test for installer that brings a cluster up for ~2 hours to allow debugging failures in a realistic environment. Like older e2e-gcp-launch jobs, this allows you to access the cluster via the console to get the secret. Make test trigger bypass 'all' for jobs that don't run all the time.
smarterclayton
force-pushed
the
launch_aws
branch
from
d2963da to
b9c3617
Compare
|
Tested in runs, merging. |
The job was first added in b9c3617 (e2e: Prepare to support new openshift-tests binary in 4.0 jobs, 2018-11-12, openshift#2108) to provide a scratch cluster for manually poking around. But we don't actually need it to gate merges, so make it optional.
4 participants
The new binary is simpler and easier to reason about.
Also add a
launch-awstest for installer to allow bringing a cluster up.Testing with openshift/installer#406 and openshift/origin#21459