Skip to content

ci-operator/jobs/openshift: Make launch-aws optional#2798

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:launch-aws-optional
Feb 7, 2019
Merged

ci-operator/jobs/openshift: Make launch-aws optional#2798
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:launch-aws-optional

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented Feb 7, 2019

The job was first added in b9c3617 (#2108) to provide a scratch cluster for manually poking around. But we don't actually need it to gate merges, so make it optional.

@wking
ci-operator/jobs/openshift: Make launch-aws optional
9c5d45f 
The job was first added in b9c3617 (e2e: Prepare to support new
openshift-tests binary in 4.0 jobs, 2018-11-12, openshift#2108) to provide a
scratch cluster for manually poking around.  But we don't actually
need it to gate merges, so make it optional.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2019
@petr-muller
Copy link
Copy Markdown
Member

petr-muller commented Feb 7, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2019
@openshift-merge-robot openshift-merge-robot merged commit 211cc73 into openshift:master Feb 7, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 7, 2019

@wking: Updated the job-config configmap in namespace ci using the following files:

  • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
  • key openshift-origin-master-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-master-presubmits.yaml
Details

In response to this:

The job was first added in b9c3617 (#2108) to provide a scratch cluster for manually poking around. But we don't actually need it to gate merges, so make it optional.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the launch-aws-optional branch February 14, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@petr-muller petr-muller

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wking @petr-muller @openshift-ci-robot @openshift-merge-robot