Skip to content

Cleanup techpreview workflows#21227

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
JoelSpeed:cleanup-tpnu
Jan 18, 2022
Merged

Cleanup techpreview workflows#21227
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
JoelSpeed:cleanup-tpnu

Conversation

@JoelSpeed
Copy link
Copy Markdown
Contributor

@JoelSpeed JoelSpeed commented Aug 19, 2021 •
edited
Loading

It was suggested that I might be able to make the techpreview workflow simpler by directly referncing the ipi-conf-techpreview and using the regular ipi-aws-pre

This allows us to remove a bunch of configuration while maintaining the same jobs, so in theory should be easier to maintain in the future

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2021
@openshift-ci openshift-ci Bot requested review from csrwng and staebler August 19, 2021 14:53
@JoelSpeed JoelSpeed mentioned this pull request Aug 20, 2021
Merged
@JoelSpeed JoelSpeed changed the title WIP: Cleanup AWS techpreview workflow Cleanup techpreview workflows Aug 25, 2021
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2021
@JoelSpeed
Copy link
Copy Markdown
Contributor Author

JoelSpeed commented Aug 25, 2021

/assign @deads2k

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 31, 2021
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2021
@JoelSpeed
Copy link
Copy Markdown
Contributor Author

JoelSpeed commented Sep 7, 2021

These tests have failed because of openshift/origin#26449, which is fixing a previous PR which broke the techpreview jobs across the board

@pierreprinetti pierreprinetti mentioned this pull request Sep 8, 2021
Merged
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 26, 2021

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 26, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 10, 2022

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 10, 2022
staebler
staebler reviewed Jan 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 17, 2022
@staebler
Copy link
Copy Markdown
Contributor

staebler commented Jan 17, 2022

/remove lifecycle-rotten

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 18, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 18, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 18, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 18, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 18, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 18, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 18, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 18, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@JoelSpeed
Copy link
Copy Markdown
Contributor Author

JoelSpeed commented Jan 18, 2022

The owners check is failing because we removed the 2 folders, it is not understanding the removal of the folders for some reason. Have pinged DPTP about double checking it and getting an override

@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 18, 2022
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2022
@openshift-ci openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2022
@droslean
Copy link
Copy Markdown
Member

droslean commented Jan 18, 2022

/lgtm
/approve
/hold

Holiding for the rehearsals. Feel free to /hold cancel if there is no point in waiting.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2022
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, JoelSpeed, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2022
@JoelSpeed
Copy link
Copy Markdown
Contributor Author

JoelSpeed commented Jan 18, 2022

/hold cancel

The jobs seem to be working as expected, the failure on AWS is unrelated

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 18, 2022

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/pj-rehearse-blocking 4575b9a29008a5ab6f031d02544b9a25d90a4a74 link /test pj-rehearse-blocking
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-openstack-techpreview-parallel 09b1206ec994426c695b42301279555860ce989f link /test pj-rehearse
ci/rehearse/openshift/openshift-controller-manager/release-4.11/openshift-e2e-aws-builds-techpreview b0dd6f9 link unknown /test pj-rehearse
ci/prow/pj-rehearse b0dd6f9 link false /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-azure-techpreview-serial b0dd6f9 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 36498ca into openshift:master Jan 18, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 18, 2022

@JoelSpeed: Updated the step-registry configmap in namespace ci at cluster app.ci using the following files:

  • key csi-driver-shared-resource-e2e-techpreview-workflow.yaml using file ci-operator/step-registry/csi-driver-shared-resource/e2e/techpreview/csi-driver-shared-resource-e2e-techpreview-workflow.yaml
  • key OWNERS using file ``
  • key ipi-aws-pre-techpreview-chain.metadata.json using file ``
  • key ipi-aws-pre-techpreview-chain.yaml using file ``
  • key OWNERS using file ``
  • key ipi-azure-pre-techpreview-chain.metadata.json using file ``
  • key ipi-azure-pre-techpreview-chain.yaml using file ``
  • key OWNERS using file ``
  • key ipi-conf-aws-techpreview-chain.metadata.json using file ``
  • key ipi-conf-aws-techpreview-chain.yaml using file ``
  • key OWNERS using file ``
  • key ipi-conf-azure-techpreview-chain.metadata.json using file ``
  • key ipi-conf-azure-techpreview-chain.yaml using file ``
  • key OWNERS using file ``
  • key ipi-conf-openstack-techpreview-chain.metadata.json using file ``
  • key ipi-conf-openstack-techpreview-chain.yaml using file ``
  • key OWNERS using file ``
  • key ipi-openstack-pre-techpreview-chain.metadata.json using file ``
  • key ipi-openstack-pre-techpreview-chain.yaml using file ``
  • key openshift-e2e-aws-builds-techpreview-workflow.yaml using file ci-operator/step-registry/openshift/e2e/aws/builds/techpreview/openshift-e2e-aws-builds-techpreview-workflow.yaml
  • key openshift-e2e-aws-techpreview-workflow.yaml using file ci-operator/step-registry/openshift/e2e/aws/techpreview/openshift-e2e-aws-techpreview-workflow.yaml
  • key openshift-e2e-aws-techpreview-serial-workflow.yaml using file ci-operator/step-registry/openshift/e2e/aws/techpreview/serial/openshift-e2e-aws-techpreview-serial-workflow.yaml
  • key openshift-e2e-azure-techpreview-workflow.yaml using file ci-operator/step-registry/openshift/e2e/azure/techpreview/openshift-e2e-azure-techpreview-workflow.yaml
  • key openshift-e2e-azure-techpreview-serial-workflow.yaml using file ci-operator/step-registry/openshift/e2e/azure/techpreview/serial/openshift-e2e-azure-techpreview-serial-workflow.yaml
  • key openshift-e2e-openstack-techpreview-workflow.yaml using file ci-operator/step-registry/openshift/e2e/openstack/techpreview/openshift-e2e-openstack-techpreview-workflow.yaml
Details

In response to this:

It was suggested that I might be able to make the techpreview workflow simpler by directly referncing the ipi-conf-techpreview and using the regular ipi-aws-pre

This allows us to remove a bunch of configuration while maintaining the same jobs, so in theory should be easier to maintain in the future

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csrwng csrwng Awaiting requested review from csrwng

1 more reviewer

@staebler staebler staebler left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@deads2k deads2k

@droslean droslean

@staebler staebler

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JoelSpeed @openshift-bot @staebler @droslean @deads2k @openshift-merge-robot