Bug 1998029: CustomNoUpgrade should not fire no-upgrade failures by pierreprinetti · Pull Request #26449 · openshift/origin

pierreprinetti · 2021-09-03T09:47:59Z

Fixup of 5fb0f99 (#26430)

The commit that is being fixed-up introduced a check against a message
that is not implemented anywhere, thus rendering the function
isKubeAPIUpgradableNoUpgradeCondition unusable.

This patch removes the check on the condition message.

/cc JoelSpeed
/assign deads2k

Fixup of 5fb0f99 The commit that is being fixed-up introduced a check against a message that is not implemented anywhere, thus rendering the function `isKubeAPIUpgradableNoUpgradeCondition` unusable. This patch removes the check on the condition message.

openshift-ci · 2021-09-03T09:48:03Z

@pierreprinetti: This pull request references Bugzilla bug 1998029, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1998029: CustomNoUpgrade should not fire no-upgrade failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2021-09-03T09:48:34Z

/bugzilla refresh

openshift-ci · 2021-09-03T09:49:41Z

@pierreprinetti: This pull request references Bugzilla bug 1998029, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (pprinett@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mdbooth

This looks much more robust. I wonder if there was a reason it was originally implemented this way? @JoelSpeed ?

JoelSpeed · 2021-09-03T10:16:57Z

I wonder if there was a reason it was originally implemented this way? @JoelSpeed ?

I think I was just being very explicit about the exact nature of the condition applied by the api server operator, this is fine as well though

/lgtm

Fedosin

/lgtm

openshift-ci · 2021-09-03T11:35:04Z

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-cmd	`8b89e16`	link	`/test e2e-agnostic-cmd`
ci/prow/e2e-aws-single-node	`8b89e16`	link	`/test e2e-aws-single-node`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pierreprinetti · 2021-09-03T12:43:31Z

/skip

openshift-merge-robot · 2021-09-06T07:20:42Z

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

openshift-ci · 2021-09-06T07:20:45Z

@openshift-merge-robot: This pull request references Bugzilla bug 1998029, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2021-09-06T13:06:34Z

/bugzilla refresh

openshift-ci · 2021-09-06T13:06:39Z

@pierreprinetti: This pull request references Bugzilla bug 1998029, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (pprinett@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2021-09-08T08:52:01Z

I believe this requires the attention of @deads2k

Without this patch, we can't get CCM tests green unfortunately (cf openshift/release#21227)

pierreprinetti · 2021-09-08T13:10:02Z

/assign mfojtik

pierreprinetti · 2021-09-13T08:23:48Z

/cc @bparees

bparees · 2021-09-13T18:24:40Z

/approve

openshift-ci · 2021-09-13T18:25:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, Fedosin, JoelSpeed, mdbooth, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/operators/OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-09-13T23:28:31Z

@pierreprinetti: All pull requests linked via external trackers have merged:

Bugzilla bug 1998029 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1998029: CustomNoUpgrade should not fire no-upgrade failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2021-11-18T05:14:53Z

/cherrypick release-4.9

openshift-cherrypick-robot · 2021-11-18T05:17:53Z

@wking: new pull request created: #26615

Details

In response to this:

/cherrypick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot assigned deads2k Sep 3, 2021

openshift-ci Bot requested a review from JoelSpeed September 3, 2021 09:48

openshift-ci Bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 3, 2021

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 3, 2021

openshift-ci Bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 3, 2021

mdbooth approved these changes Sep 3, 2021

View reviewed changes

openshift-ci Bot assigned JoelSpeed Sep 3, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021

Fedosin reviewed Sep 3, 2021

View reviewed changes

openshift-ci Bot assigned Fedosin Sep 3, 2021

openshift-ci Bot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 6, 2021

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 6, 2021

openshift-ci Bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 6, 2021

pierreprinetti mentioned this pull request Sep 6, 2021

cloud-provider-openstack: Add CCM presubmits openshift/release#21117

Merged

This was referenced Sep 7, 2021

Add TechPreviewNoUpgrade Periodics for GCP and VSphere openshift/release#21338

Merged

Cleanup techpreview workflows openshift/release#21227

Merged

openshift-ci Bot assigned mfojtik Sep 8, 2021

openshift-ci Bot requested a review from bparees September 13, 2021 08:23

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021

openshift-merge-robot merged commit 37a0667 into openshift:master Sep 13, 2021

pierreprinetti deleted the custom_no_upgrade_fixup branch September 14, 2021 08:25

openshift-cherrypick-robot mentioned this pull request Nov 18, 2021

Bug 2024433: CustomNoUpgrade should not fire no-upgrade failures #26615

Merged

Conversation

pierreprinetti commented Sep 3, 2021

Uh oh!

openshift-ci Bot commented Sep 3, 2021

Uh oh!

pierreprinetti commented Sep 3, 2021

Uh oh!

openshift-ci Bot commented Sep 3, 2021

Uh oh!

mdbooth left a comment

Choose a reason for hiding this comment

Uh oh!

JoelSpeed commented Sep 3, 2021

Uh oh!

Fedosin left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Sep 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pierreprinetti commented Sep 3, 2021

Uh oh!

openshift-merge-robot commented Sep 6, 2021

Uh oh!

openshift-ci Bot commented Sep 6, 2021

Uh oh!

pierreprinetti commented Sep 6, 2021

Uh oh!

openshift-ci Bot commented Sep 6, 2021

Uh oh!

pierreprinetti commented Sep 8, 2021

Uh oh!

pierreprinetti commented Sep 8, 2021

Uh oh!

pierreprinetti commented Sep 13, 2021

Uh oh!

bparees commented Sep 13, 2021

Uh oh!

openshift-ci Bot commented Sep 13, 2021

Uh oh!

openshift-ci Bot commented Sep 13, 2021

Uh oh!

wking commented Nov 18, 2021

Uh oh!

openshift-cherrypick-robot commented Nov 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

openshift-ci Bot commented Sep 3, 2021 •

edited

Loading