Skip to content

cloud-provider-openstack: Add CCM presubmits#21117

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:cpo_ccm
Oct 4, 2021
Merged

cloud-provider-openstack: Add CCM presubmits#21117
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:cpo_ccm

Conversation

@pierreprinetti
Copy link
Copy Markdown
Contributor

@pierreprinetti pierreprinetti commented Aug 16, 2021 •
edited by openshift-ci Bot
Loading

This patch adds two new jobs to the cloud-provider-openstack presubmits:

  • e2e-openstack-ccm adds the CCM feature gate to OpenShift prior to
    running the test suite
  • e2e-openstack-ccm-day1 adds the CCM feature gate to the manifests
    during the OpenShift installation process, then runs the test suite.

Both jobs are always_run: false and optional: true for the time
being.

Implements OSASINFRA-2559

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 16, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot requested review from Fedosin and mandre August 16, 2021 05:10
@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Aug 16, 2021
@openshift-ci openshift-ci Bot requested a review from mdbooth August 16, 2021 08:45
@pierreprinetti pierreprinetti force-pushed the cpo_ccm branch 2 times, most recently from 09cd502 to a87bc91 Compare August 18, 2021 15:55
@openshift-ci openshift-ci Bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 18, 2021
@pierreprinetti pierreprinetti force-pushed the cpo_ccm branch 3 times, most recently from b2b47fa to 58103a6 Compare August 18, 2021 16:09
@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Aug 18, 2021

/test all

@pierreprinetti pierreprinetti changed the title [wip] cloud-provider-openstack: Add CCM presubmits cloud-provider-openstack: Add CCM presubmits Aug 18, 2021
@pierreprinetti pierreprinetti marked this pull request as ready for review August 18, 2021 16:12
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2021
@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Aug 18, 2021

/hold to see what the CI will tell us

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2021
@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Aug 18, 2021

Oh noes, both rehearsals hit secgroup quota.

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Aug 18, 2021

/retest

1 similar comment
@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Aug 19, 2021

/retest

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Aug 19, 2021

/hold cancel
This looks good to go. The errors look legit and we can start working on them right from the production code repos.

WDYT @mdbooth ?

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2021
@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Aug 26, 2021

/retest

2 similar comments
@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Aug 26, 2021

/retest

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Aug 31, 2021

/retest

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 1, 2021

Depends on openshift/origin#26430

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 3, 2021

/retest

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 6, 2021

Depends on openshift/origin#26449

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 14, 2021

CustomNoUpgrade is seemingly not causing any more problems.

What do you think @mdbooth? Shall we merge and work in repo?

Triggering a retest just in case.
/retest

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 28, 2021

/retest

@pierreprinetti pierreprinetti force-pushed the cpo_ccm branch 2 times, most recently from 521355a to 0dccba2 Compare September 29, 2021 13:44
@pierreprinetti
cloud-provider-openstack: Add CCM presubmits
7226007 
This patch adds two new jobs to the cloud-provider-openstack presubmits:
* `e2e-openstack-ccm` adds the CCM feature gate to OpenShift prior to
  running the test suite
* `e2e-openstack-ccm-install` adds the CCM feature gate to the manifests
  during the OpenShift installation process, then runs the test suite.

Both jobs have `always_run: false` and `optional: true` for the time
being.

Both jobs have the alert check in TEST_SKIPS until we figure out how to
ignore CustomNoUpgrades alerts in Origin directly.
@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 30, 2021

@mdbooth
One way or the other, we got rid of thr noUpgrade alerts. Shall we merge and iterate?

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Oct 4, 2021

/test pj-rehearse

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 4, 2021

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cloud-provider-openstack/master/e2e-openstack-ccm 7226007 link unknown /test pj-rehearse
ci/prow/pj-rehearse 7226007 link false /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mdbooth
mdbooth approved these changes Oct 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mdbooth mdbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Lets debug the remaining failures with the job in place. It's optional and doesn't run by default, so this isn't breaking anybody for now.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d8909a6 into openshift:master Oct 4, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 4, 2021

@pierreprinetti: Updated the following 3 configmaps:

  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/openstack/ccm/install/OWNERS
    • key openshift-e2e-openstack-ccm-install-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/openstack/ccm/install/openshift-e2e-openstack-ccm-install-workflow.metadata.json
    • key openshift-e2e-openstack-ccm-install-workflow.yaml using file ci-operator/step-registry/openshift/e2e/openstack/ccm/install/openshift-e2e-openstack-ccm-install-workflow.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cloud-provider-openstack-master.yaml using file ci-operator/config/openshift/cloud-provider-openstack/openshift-cloud-provider-openstack-master.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cloud-provider-openstack-master-presubmits.yaml using file ci-operator/jobs/openshift/cloud-provider-openstack/openshift-cloud-provider-openstack-master-presubmits.yaml
Details

In response to this:

This patch adds two new jobs to the cloud-provider-openstack presubmits:

  • e2e-openstack-ccm adds the CCM feature gate to OpenShift prior to
    running the test suite
  • e2e-openstack-ccm-day1 adds the CCM feature gate to the manifests
    during the OpenShift installation process, then runs the test suite.

Both jobs are always_run: false and optional: true for the time
being.

Implements OSASINFRA-2559

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the cpo_ccm branch October 4, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fedosin Fedosin Awaiting requested review from Fedosin

@mandre mandre Awaiting requested review from mandre

1 more reviewer

@mdbooth mdbooth mdbooth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdbooth mdbooth

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pierreprinetti @mdbooth @openshift-merge-robot