Skip to content

Bug 1998029: CustomNoUpgrade should not fire no-upgrade failures#26430

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:custom_no_upgrade
Sep 3, 2021
Merged

Bug 1998029: CustomNoUpgrade should not fire no-upgrade failures#26430
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:custom_no_upgrade

Conversation

@pierreprinetti
Copy link
Copy Markdown
Contributor

@pierreprinetti pierreprinetti commented Aug 26, 2021

CustomNoUpgrade should be treated just as TechPreviewNoUpgrade, and
should not be a condition that triggers no-upgrade failures in tests.
This is useful in cases where we want to test a specific set of feature
gates in isolation from other tech preview feature gates.

Specifically we are using CustomNoUpgrade to test
external-cloud-provider CCM promotions in isolation in
https://github.com/openshift/release/blob/992f297ef8a1ba749f3a0b9b40438696f18a1bc4/ci-operator/step-registry/ccm/conf/pre-create-feature-gate/ccm-conf-pre-create-feature-gate-commands.sh#L22

Co-Authored-By: Matthew Booth mbooth@redhat.com

@pierreprinetti @mdbooth
CustomNoUpgrade should not fire no-upgrade failures
5fb0f99 
CustomNoUpgrade should be treated just as TechPreviewNoUpgrade, and
should not be a condition that triggers no-upgrade failures in tests.
This is useful in cases where we want to test a specific set of feature
gates in isolation from other tech preview feature gates.

Specifically we are using CustomNoUpgrade to test
external-cloud-provider CCM promotions in isolation in
https://github.com/openshift/release/blob/992f297ef8a1ba749f3a0b9b40438696f18a1bc4/ci-operator/step-registry/ccm/conf/pre-create-feature-gate/ccm-conf-pre-create-feature-gate-commands.sh#L22

Co-Authored-By: Matthew Booth <mbooth@redhat.com>
@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Aug 26, 2021

/cc JoelSpeed

@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Aug 26, 2021

Changes make sense to me, and shouldn't affect the existing tests, LGTM

@pierreprinetti pierreprinetti changed the title CustomNoUpgrade should not fire no-upgrade failures Bug 1998029: CustomNoUpgrade should not fire no-upgrade failures Aug 26, 2021
@openshift-ci openshift-ci Bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 26, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 26, 2021

@pierreprinetti: This pull request references Bugzilla bug 1998029, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1998029: CustomNoUpgrade should not fire no-upgrade failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Aug 26, 2021

/retest-required

1 similar comment
@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Aug 26, 2021

/retest-required

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Aug 26, 2021

/assign @ecordell
as the bot suggests

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Aug 27, 2021

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 27, 2021

@pierreprinetti: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-cmd 5fb0f99 link /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 1, 2021

/assign njhale

@pierreprinetti pierreprinetti mentioned this pull request Sep 1, 2021
Merged
@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 1, 2021

/assign @kevinrizza
as @benluddy suggested (thanks)

@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Sep 1, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2021
@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 2, 2021

Apparently I was chasing the wrong team.

Let's try again!

/assign bparees

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 2, 2021

So apparently, the right person here might be @deads2k instead.

/assign @deads2k

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Sep 2, 2021

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@timflannagan
Copy link
Copy Markdown
Contributor

timflannagan commented Sep 2, 2021

/uncc

@openshift-ci openshift-ci Bot removed the request for review from timflannagan September 2, 2021 17:55
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 2, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 2, 2021

/skip

@openshift-merge-robot openshift-merge-robot merged commit c1eb82a into openshift:master Sep 3, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 3, 2021

@pierreprinetti: All pull requests linked via external trackers have merged:

Bugzilla bug 1998029 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1998029: CustomNoUpgrade should not fire no-upgrade failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the custom_no_upgrade branch September 3, 2021 07:58
@pierreprinetti pierreprinetti mentioned this pull request Sep 3, 2021
Merged
@wking wking mentioned this pull request Nov 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@benluddy benluddy Awaiting requested review from benluddy

Assignees

@ecordell ecordell

@njhale njhale

@bparees bparees

@kevinrizza kevinrizza

@deads2k deads2k

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@pierreprinetti @JoelSpeed @deads2k @openshift-bot @timflannagan @ecordell @njhale @bparees @kevinrizza @openshift-merge-robot