Skip to content

Conversation

@soltysh
Copy link

@soltysh soltysh commented Dec 2, 2021

/hold
this can go after openshift/library-go#1257 lands

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2021

@soltysh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/library-go/master/e2e-aws-encryption 18c743f link unknown /test pj-rehearse
ci/rehearse/openshift/library-go/master/verify 18c743f link unknown /test pj-rehearse
ci/rehearse/openshift/library-go/master/verify-deps 18c743f link unknown /test pj-rehearse
ci/rehearse/openshift/library-go/master/unit 18c743f link unknown /test pj-rehearse
ci/prow/pj-rehearse 18c743f link false /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Author

soltysh commented Dec 2, 2021

/hold cancel
actually we need to do it this first and then fix kas-o.
/assign @sttts

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2021
@soltysh
Copy link
Author

soltysh commented Dec 2, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2021
@sttts
Copy link
Contributor

sttts commented Dec 2, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2021
@soltysh
Copy link
Author

soltysh commented Dec 2, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit a31d708 into openshift:master Dec 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2021

@soltysh: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-library-go-master.yaml using file ci-operator/config/openshift/library-go/openshift-library-go-master.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-library-go-master-presubmits.yaml using file ci-operator/jobs/openshift/library-go/openshift-library-go-master-presubmits.yaml
Details

In response to this:

/hold
this can go after openshift/library-go#1257 lands

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants