Skip to content

Conversation

@damemi
Copy link

@damemi damemi commented Dec 2, 2021

Needed for go1.17 bumps for 1.23 rebase
Following the same steps that were done in #24201 for library-go

.ci-operator.yaml is added in the following PRs:

@openshift-ci openshift-ci bot requested a review from soltysh December 2, 2021 19:23
Copy link
Author

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @soltysh
ptal

@openshift-ci openshift-ci bot requested review from deads2k and jwforres December 2, 2021 19:25
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2021

@damemi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/api/master/verify-deps 6553afb link unknown /test pj-rehearse
ci/rehearse/openshift/api/master/unit 6553afb link unknown /test pj-rehearse
ci/rehearse/openshift/api/master/build 6553afb link unknown /test pj-rehearse
ci/rehearse/openshift/api/master/verify 6553afb link unknown /test pj-rehearse
ci/rehearse/openshift/api/master/verify-client-go 6553afb link unknown /test pj-rehearse
ci/rehearse/openshift/apiserver-library-go/master/unit 6553afb link unknown /test pj-rehearse
ci/rehearse/openshift/apiserver-library-go/master/verify-deps 6553afb link unknown /test pj-rehearse
ci/rehearse/openshift/apiserver-library-go/master/verify 6553afb link unknown /test pj-rehearse
ci/rehearse/openshift/client-go/master/verify 6553afb link unknown /test pj-rehearse
ci/prow/pj-rehearse 6553afb link false /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e5f0f6e into openshift:master Dec 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2021

@damemi: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-api-master.yaml using file ci-operator/config/openshift/api/openshift-api-master.yaml
    • key openshift-apiserver-library-go-master.yaml using file ci-operator/config/openshift/apiserver-library-go/openshift-apiserver-library-go-master.yaml
    • key openshift-client-go-master.yaml using file ci-operator/config/openshift/client-go/openshift-client-go-master.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-api-master-presubmits.yaml using file ci-operator/jobs/openshift/api/openshift-api-master-presubmits.yaml
    • key openshift-apiserver-library-go-master-presubmits.yaml using file ci-operator/jobs/openshift/apiserver-library-go/openshift-apiserver-library-go-master-presubmits.yaml
    • key openshift-client-go-master-presubmits.yaml using file ci-operator/jobs/openshift/client-go/openshift-client-go-master-presubmits.yaml
Details

In response to this:

Needed for go1.17 bumps for 1.23 rebase
Following the same steps that were done in #24201 for library-go

.ci-operator.yaml is added in the following PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants