Add support for installing pre create route53 hostedzone cluster on AWS #27656

mhanss · 2022-04-07T14:00:48Z

Add support for installing pre created route53 cluster.

chain:
  as: cucushift-installer-rehearse-aws-ipi-byo-route53-provision
  steps:
    - ref: aws-provision-vpc-shared
    - ref: aws-provision-route53-private-hosted-zone
    - ref: ipi-conf
    - ref: ipi-conf-aws-custom-vpc
    - ref: ipi-conf-aws-byo-route53
    - ref: ipi-conf-aws
    - ref: ipi-install-monitoringpvc
    - chain: ipi-install
  documentation: |-
    Create an IPI cluster on AWS for QE e2e tests.

jianlinliu · 2022-04-08T06:15:32Z

.../aws/ipi/route53/provision/cucushift-installer-rehearse-aws-ipi-route53-provision-chain.yaml

Suggest to move ipi-conf-aws behind ipi-conf-aws-route53 step.

jianlinliu · 2022-04-08T06:16:05Z

ci-operator/step-registry/ipi/conf/aws/route53/ipi-conf-aws-route53-commands.sh

suggest to remove this irrelevant setting

jianlinliu · 2022-04-08T06:18:24Z

ci-operator/step-registry/aws/provision/route53/aws-provision-route53-commands.sh

I saw we did not install jq in ci-operator/step-registry/aws/deprovision/route53/aws-deprovision-route53-commands.sh, so shall we explicitly install it here?

Yes, here it is required to get the hostedzone and change id from the json file.

I meant jq should be already installed, if not, aws-deprovision-route53 ref would fail. So sounds like we do not need to install jq here.

Yes, no need to install jq.

jianlinliu · 2022-04-08T06:22:08Z

ci-operator/step-registry/ipi/conf/aws/route53/ipi-conf-aws-route53-ref.yaml

sounds like we do not need this env var in this case

Removed it from the file.

jianlinliu · 2022-04-08T06:25:38Z

ci-operator/step-registry/ipi/conf/aws/route53/ipi-conf-aws-route53-commands.sh

Personally I think we do not have to print install-config anywhere.

Even we check the install-config.yaml files, this patch will add proxy and additionalTrustBundle there, especially when install-config.yaml never set these items, this will easily confuse our debugging.

Removed code to print install-config file

yunjiang29 · 2022-04-11T06:30:08Z

ci-operator/step-registry/aws/provision/route53/aws-provision-route53-commands.sh

IMO, it's better that update the name to reflect the AWS resources we are trying to create, like aws-provision-route53-private-hosted-zone (the private-hosted-zone is a subfolder of route53)

yunjiang29 · 2022-04-11T06:43:34Z

ci-operator/step-registry/ipi/conf/aws/route53/ipi-conf-aws-route53-commands.sh

publish will be controlled by system environment in *-provision chain, like https://github.com/openshift/release/pull/24888/files#diff-55d9cca8aaec70f1288e64a0af48754c084edcd57938c5b53ade1701ae6c4974R22-R24, so it should be removed from here.

there are some conflicts with #24888, the subnet and AZ should be set in ipi-conf-aws-custom-vpc, which is newly introduced in #24888, but it has not been merged yet, hope it can be merged within this week.

eventually, this part should be:

cat > "${CONFIG_ROUTE53_HOSTEDZONE}" << EOF platform: aws: hostedZone: $(cat "${hostedzoneid}") EOF

Sure, I will update once this #24888 merged to the master.

yunjiang29 · 2022-04-11T06:46:14Z

.../aws/ipi/route53/provision/cucushift-installer-rehearse-aws-ipi-route53-provision-chain.yaml

as comment in https://github.com/openshift/release/pull/27656/files#r846992212, the step ipi-conf-aws-custom-vpc will be required before ipi-conf-aws

mhanss · 2022-04-11T19:18:16Z

/retest

mhanss · 2022-05-02T07:38:04Z

/retest-required

wking · 2022-05-02T16:06:53Z

ci-operator/step-registry/ipi/conf/aws/byo-route53/ipi-conf-aws-byo-route53-commands.sh

No need to put this patch file in SHARED_DIR, is there? It's only consumed locally a few lines below. Maybe /tmp/install-config.yaml.patch?

wking

/lgtm

openshift-ci · 2022-05-02T16:25:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianlinliu, mhanss, wking, yunjiang29

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/verification-tests/OWNERS~~ [jianlinliu]
~~ci-operator/jobs/openshift/verification-tests/OWNERS~~ [jianlinliu]
~~ci-operator/step-registry/aws/OWNERS~~ [jianlinliu,wking,yunjiang29]
~~ci-operator/step-registry/cucushift/installer/rehearse/aws/OWNERS~~ [jianlinliu,yunjiang29]
~~ci-operator/step-registry/ipi/OWNERS~~ [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mhanss · 2022-05-03T07:53:52Z

/unhold

openshift-ci · 2022-05-03T08:14:37Z

@mhanss: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-05-03T08:16:47Z

@mhanss: Updated the following 3 configmaps:

ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
- key openshift-verification-tests-master__installer-rehearse.yaml using file ci-operator/config/openshift/verification-tests/openshift-verification-tests-master__installer-rehearse.yaml
job-config-master-periodics configmap in namespace ci at cluster app.ci using the following files:
- key openshift-verification-tests-master-periodics.yaml using file ci-operator/jobs/openshift/verification-tests/openshift-verification-tests-master-periodics.yaml
step-registry configmap in namespace ci at cluster app.ci using the following files:
- key OWNERS using file ci-operator/step-registry/aws/deprovision/route53/OWNERS
- key OWNERS using file ci-operator/step-registry/aws/deprovision/route53/private-hosted-zone/OWNERS
- key aws-deprovision-route53-private-hosted-zone-commands.sh using file ci-operator/step-registry/aws/deprovision/route53/private-hosted-zone/aws-deprovision-route53-private-hosted-zone-commands.sh
- key aws-deprovision-route53-private-hosted-zone-ref.metadata.json using file ci-operator/step-registry/aws/deprovision/route53/private-hosted-zone/aws-deprovision-route53-private-hosted-zone-ref.metadata.json
- key aws-deprovision-route53-private-hosted-zone-ref.yaml using file ci-operator/step-registry/aws/deprovision/route53/private-hosted-zone/aws-deprovision-route53-private-hosted-zone-ref.yaml
- key OWNERS using file ci-operator/step-registry/aws/provision/route53/OWNERS
- key OWNERS using file ci-operator/step-registry/aws/provision/route53/private-hosted-zone/OWNERS
- key aws-provision-route53-private-hosted-zone-commands.sh using file ci-operator/step-registry/aws/provision/route53/private-hosted-zone/aws-provision-route53-private-hosted-zone-commands.sh
- key aws-provision-route53-private-hosted-zone-ref.metadata.json using file ci-operator/step-registry/aws/provision/route53/private-hosted-zone/aws-provision-route53-private-hosted-zone-ref.metadata.json
- key aws-provision-route53-private-hosted-zone-ref.yaml using file ci-operator/step-registry/aws/provision/route53/private-hosted-zone/aws-provision-route53-private-hosted-zone-ref.yaml
- key OWNERS using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/byo-route53/OWNERS
- key cucushift-installer-rehearse-aws-ipi-byo-route53-workflow.metadata.json using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/byo-route53/cucushift-installer-rehearse-aws-ipi-byo-route53-workflow.metadata.json
- key cucushift-installer-rehearse-aws-ipi-byo-route53-workflow.yaml using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/byo-route53/cucushift-installer-rehearse-aws-ipi-byo-route53-workflow.yaml
- key OWNERS using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/byo-route53/deprovision/OWNERS
- key cucushift-installer-rehearse-aws-ipi-byo-route53-deprovision-chain.metadata.json using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/byo-route53/deprovision/cucushift-installer-rehearse-aws-ipi-byo-route53-deprovision-chain.metadata.json
- key cucushift-installer-rehearse-aws-ipi-byo-route53-deprovision-chain.yaml using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/byo-route53/deprovision/cucushift-installer-rehearse-aws-ipi-byo-route53-deprovision-chain.yaml
- key OWNERS using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/byo-route53/provision/OWNERS
- key cucushift-installer-rehearse-aws-ipi-byo-route53-provision-chain.metadata.json using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/byo-route53/provision/cucushift-installer-rehearse-aws-ipi-byo-route53-provision-chain.metadata.json
- key cucushift-installer-rehearse-aws-ipi-byo-route53-provision-chain.yaml using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/byo-route53/provision/cucushift-installer-rehearse-aws-ipi-byo-route53-provision-chain.yaml
- key OWNERS using file ci-operator/step-registry/ipi/conf/aws/byo-route53/OWNERS
- key ipi-conf-aws-byo-route53-commands.sh using file ci-operator/step-registry/ipi/conf/aws/byo-route53/ipi-conf-aws-byo-route53-commands.sh
- key ipi-conf-aws-byo-route53-ref.metadata.json using file ci-operator/step-registry/ipi/conf/aws/byo-route53/ipi-conf-aws-byo-route53-ref.metadata.json
- key ipi-conf-aws-byo-route53-ref.yaml using file ci-operator/step-registry/ipi/conf/aws/byo-route53/ipi-conf-aws-byo-route53-ref.yaml

Details

In response to this:

Add support for installing pre created route53 cluster.

chain:
 as: cucushift-installer-rehearse-aws-ipi-byo-route53-provision
 steps:
   - ref: aws-provision-vpc-shared
   - ref: aws-provision-route53-private-hosted-zone
   - ref: ipi-conf
   - ref: ipi-conf-aws-custom-vpc
   - ref: ipi-conf-aws-byo-route53
   - ref: ipi-conf-aws
   - ref: ipi-install-monitoringpvc
   - chain: ipi-install
 documentation: |-
   Create an IPI cluster on AWS for QE e2e tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mhanss changed the title ~~Add support for installing pre create route53 hostedzone cluster on AWS~~ WIP: Add support for installing pre create route53 hostedzone cluster on AWS Apr 7, 2022

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2022

openshift-ci bot requested review from droslean and gpei April 7, 2022 14:03

mhanss force-pushed the aws-route53 branch 9 times, most recently from 4b66749 to faf7717 Compare April 7, 2022 22:55

jianlinliu reviewed Apr 8, 2022

View reviewed changes

jianlinliu mentioned this pull request Apr 11, 2022

[QE][AWS] Add support for installing private&disconnected cluster #24888

Merged

yunjiang29 reviewed Apr 11, 2022

View reviewed changes

mhanss force-pushed the aws-route53 branch 6 times, most recently from 6ca4563 to 073c2a8 Compare April 11, 2022 17:26

mhanss changed the title ~~WIP: Add support for installing pre create route53 hostedzone cluster on AWS~~ Add support for installing pre create route53 hostedzone cluster on AWS Apr 12, 2022

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 2, 2022

mhanss force-pushed the aws-route53 branch from 36abe08 to cf4aff0 Compare May 2, 2022 07:41

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2022

mhanss force-pushed the aws-route53 branch from cf4aff0 to 4ae4c6a Compare May 2, 2022 08:12

openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 2, 2022

mhanss force-pushed the aws-route53 branch from 4be7225 to 15ebde2 Compare May 2, 2022 08:24

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2022

mhanss force-pushed the aws-route53 branch 4 times, most recently from 68d6a99 to 991d31d Compare May 2, 2022 08:40

openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 2, 2022

mhanss force-pushed the aws-route53 branch 2 times, most recently from de01e57 to 67a0359 Compare May 2, 2022 08:47

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2022

wking reviewed May 2, 2022

View reviewed changes

Add support for installing pre create route53 hostedzone cluster on AWS

a63270b

mhanss force-pushed the aws-route53 branch from 67a0359 to a63270b Compare May 2, 2022 16:12

wking approved these changes May 2, 2022

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2022

openshift-merge-robot merged commit 0032770 into openshift:master May 3, 2022

mhanss deleted the aws-route53 branch May 3, 2022 08:56

Add support for installing pre create route53 hostedzone cluster on AWS #27656

Add support for installing pre create route53 hostedzone cluster on AWS #27656

Uh oh!

Conversation

mhanss commented Apr 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jianlinliu Apr 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jianlinliu Apr 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mhanss commented Apr 11, 2022

Uh oh!

mhanss commented May 2, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wking left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented May 2, 2022

Uh oh!

mhanss commented May 3, 2022

Uh oh!

openshift-ci bot commented May 3, 2022

Uh oh!

openshift-ci bot commented May 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mhanss commented Apr 7, 2022 •

edited

Loading

jianlinliu Apr 11, 2022 •

edited

Loading

jianlinliu Apr 8, 2022 •

edited

Loading