Skip to content

OKD: Fix machine-os-content builds#31963

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
LorbusChris:fixup-okd-machine-os
Sep 2, 2022
Merged

OKD: Fix machine-os-content builds#31963
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
LorbusChris:fixup-okd-machine-os

Conversation

@LorbusChris
Copy link
Copy Markdown
Contributor

PR #31663 introduced a change
that was supposed to first build and tag fedora-coreos, and then tag
that image as machine-os-content, too.
However it seems to not work as expected.
This change should fix that.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2022
@LorbusChris LorbusChris changed the title OKD: Fix MCO machine-os-content builds OKD: Fix machine-os-content builds Sep 2, 2022
PR openshift#31663 introduced a change
that was supposed to first build and tag `fedora-coreos`, and then tag
that image as `machine-os-content`, too.
However it seems to not work as expected.
This change should fix that.
@LorbusChris
Copy link
Copy Markdown
Contributor Author

/cc @vrutkovs
/cc @aleskandro
master/images has passed so this seems to work

@openshift-ci openshift-ci Bot requested a review from aleskandro September 2, 2022 19:40
@aleskandro
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleskandro, LorbusChris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit dd284bb into openshift:master Sep 2, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 2, 2022

@LorbusChris: Updated the following 3 configmaps:

  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-okd-machine-os-release-4.12.yaml using file ci-operator/config/openshift/okd-machine-os/openshift-okd-machine-os-release-4.12.yaml
  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-okd-machine-os-release-4.13.yaml using file ci-operator/config/openshift/okd-machine-os/openshift-okd-machine-os-release-4.13.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-okd-machine-os-master.yaml using file ci-operator/config/openshift/okd-machine-os/openshift-okd-machine-os-master.yaml
Details

In response to this:

PR #31663 introduced a change
that was supposed to first build and tag fedora-coreos, and then tag
that image as machine-os-content, too.
However it seems to not work as expected.
This change should fix that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 2, 2022

@LorbusChris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/okd-machine-os/release-4.13/e2e-aws ef70afc link unknown /test pj-rehearse
ci/rehearse/openshift/okd-machine-os/release-4.12/e2e-aws-crun 1a375c1cbfc82e17a19ec2ad9b12722137c5fa18 link unknown /test pj-rehearse
ci/rehearse/openshift/okd-machine-os/release-4.12/e2e-gcp 1a375c1cbfc82e17a19ec2ad9b12722137c5fa18 link unknown /test pj-rehearse
ci/rehearse/openshift/okd-machine-os/release-4.13/e2e-aws-crun ef70afc link unknown /test pj-rehearse
ci/rehearse/openshift/okd-machine-os/release-4.12/e2e-aws 1a375c1cbfc82e17a19ec2ad9b12722137c5fa18 link unknown /test pj-rehearse
ci/rehearse/openshift/okd-machine-os/release-4.13/e2e-gcp ef70afc link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants