OKD-51: mco & machine-os config updates for 4.12+#31663
OKD-51: mco & machine-os config updates for 4.12+#31663openshift-merge-robot merged 6 commits intoopenshift:masterfrom
Conversation
|
Tagged /retest |
|
Thanks! I'm not sure why |
|
/test pj-rehearse |
|
/retest |
|
ok, let's get this merged |
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
The general changes look fine, although I am not familiar with the OKD specific bits.
Just as a general question, are these jobs expected to generally report success? What is the expected suite to run on the MCO PRs and should we be paying attention when they are failing?
There was a problem hiding this comment.
So this gets built by branch-ci-openshift-machine-config-operator-master-okd-images instead, I presume. Would that have to get added to per-branch (instead of just master) as well?
There was a problem hiding this comment.
yes, that image will be promoted from master-okd-images for now, until branching happens and master promotes to 4.13, at which point the promotion for release-4.12-okd-images will be enabled.
DPTP should take care of all of that when the time comes, so there should be no action required from the MCO team side.
LorbusChris
force-pushed
the
config-mco-okd
branch
from
1f18a8e to
814f10e
Compare
|
Updated, thanks for taking a look! |
LorbusChris
force-pushed
the
config-mco-okd
branch
from
814f10e to
017b0a1
Compare
LorbusChris
force-pushed
the
config-mco-okd
branch
2 times, most recently
from
efc8395 to
3cf42db
Compare
|
The rehearse e2e jobs seem to be all failing, some of them seem to be resource issues, and some not? Do you expect any of these to pass right now? |
LorbusChris
force-pushed
the
config-mco-okd
branch
from
3cf42db to
3a92417
Compare
|
@yuqi-zhang not expecting any passes on the okd e2e tests right now. |
LorbusChris
force-pushed
the
config-mco-okd
branch
from
3a92417 to
c4e0ec4
Compare
|
/assign @jupierce |
LorbusChris
force-pushed
the
config-mco-okd
branch
from
c4e0ec4 to
577ed05
Compare
LorbusChris
changed the title
…e,upgrade} tests
- Correct build root version used for 4.12+ - Build `fedora-coreos` images, and also tag them as `machine-os-content` - Build `okd-rpms` images which can be consumed by assisted-installer
LorbusChris
force-pushed
the
config-mco-okd
branch
from
577ed05 to
c2f83d1
Compare
LorbusChris
changed the title
|
/approve |
openshift-ci
Bot
added
the
approved
|
/approve |
|
/lgtm |
|
@LorbusChris: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleskandro, cgwalters, jupierce, LorbusChris The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@LorbusChris: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@LorbusChris: Updated the following 10 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PR openshift#31663 introduced a change that was supposed to first build and tag `fedora-coreos`, and then tag that image as `machine-os-content`, too. However it seems to not work as expected. This change should fix that.
PR #31663 introduced a change that was supposed to first build and tag `fedora-coreos`, and then tag that image as `machine-os-content`, too. However it seems to not work as expected. This change should fix that.
7 participants
/cc @vrutkovs
/cc @cgwalters
/cc @yuqi-zhang