Fixes the input images replacement for the initial layers of the fedora-coreos image#31971
Fixes the input images replacement for the initial layers of the fedora-coreos image#31971aleskandro wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aleskandro The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Right, we'll want to get rid of that |
|
Ok, so should I close this one? |
|
Yeah, I think so. We want to extract MCO binary from |
|
Ok, thanks @vrutkovs ... Closing |
|
@aleskandro: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @LorbusChris, the
fedora-coreosimage is based on the processed Dockerfile.template from thelayering-buildimage (Dockerfile.ci)...I see that
Dockerfile.templateessentially rebuilds the imageokd-rpmsin the third stage based on two layers (the artifacts and machine-config-operator tags) that are not replaced by the prow config...IIUC, we may want to either change the lines 1-9 of the okd-machine-os' Dockerfile.template to be
FROM registry.ci.openshift.org/origin/4.12:okd-rpms AS rpmsor the prow config for thefedora-coreosimage as in this PR. Or is it a wanted behavior?Refers #31663