Skip to content

wmco: remove golang 1.17 from base_images#32176

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
aravindhp:winc-golang-1.18-fix
Sep 12, 2022
Merged

wmco: remove golang 1.17 from base_images#32176
openshift-merge-robot merged 1 commit into
openshift:masterfrom
aravindhp:winc-golang-1.18-fix

Conversation

@aravindhp
Copy link
Copy Markdown
Contributor

master and 4.11 should only be using golang 1.18.

Master and 4.11 should only be using golang 1.18.
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@aravindhp
Copy link
Copy Markdown
Contributor Author

/approve cancel

@openshift-ci openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 9, 2022

@aravindhp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/pj-rehearse e8d6ab0 link false /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.11/azure-e2e-ccm-install e8d6ab0 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2022
@openshift-merge-robot openshift-merge-robot merged commit b14c116 into openshift:master Sep 12, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 12, 2022

@aravindhp: Updated the following 3 configmaps:

  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-community-4.11__okd.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-community-4.11__okd.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-master.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml
  • ci-operator-4.11-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.11.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.11.yaml
Details

In response to this:

master and 4.11 should only be using golang 1.18.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravindhp aravindhp deleted the winc-golang-1.18-fix branch September 12, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants