Bug 2067890: Update prometheus-operator/pkg/client by aravindhp · Pull Request #1231 · openshift/windows-machine-config-operator

aravindhp · 2022-09-01T22:59:43Z

Ran:

go get -u github.com/prometheus-operator/prometheus-operator/pkg/client
go mod tidy
go mod vendor
go mod verify

Fixes BZ#2067890

openshift-ci · 2022-09-01T22:59:47Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2022-09-01T22:59:53Z

@aravindhp: This pull request references Bugzilla bug 2067890, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.12.0) matches configured target release for branch (4.12.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @rrasouli

Details

In response to this:

Bug 2067890: Update prometheus-operator/pkg/client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aravindhp · 2022-09-01T23:00:23Z

/cc @openshift/openshift-team-windows-containers
/approve cancel

aravindhp · 2022-09-01T23:00:49Z

/cherry-pick release-4.11

openshift-cherrypick-robot · 2022-09-01T23:00:51Z

@aravindhp: once the present PR merges, I will cherry-pick it on top of release-4.11 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

saifshaikh48

/lgtm

Ran: go get -u github.com/prometheus-operator/prometheus-operator/pkg/client go mod tidy go mod vendor go mod verify Fixes BZ#2067890

aravindhp · 2022-09-07T20:45:54Z

I am investigating:

 deployment "windows-machine-config-operator" successfully rolled out
# sigs.k8s.io/json/internal/golang/encoding/json
vendor/sigs.k8s.io/json/internal/golang/encoding/json/decode.go:96:31: undefined: any
vendor/sigs.k8s.io/json/internal/golang/encoding/json/decode.go:177:35: undefined: any
vendor/sigs.k8s.io/json/internal/golang/encoding/json/decode.go:428:37: undefined: any
vendor/sigs.k8s.io/json/internal/golang/encoding/json/decode.go:937:48: undefined: any
vendor/sigs.k8s.io/json/internal/golang/encoding/json/decode.go:1143:45: undefined: any
vendor/sigs.k8s.io/json/internal/golang/encoding/json/decode.go:1160:42: undefined: any
vendor/sigs.k8s.io/json/internal/golang/encoding/json/decode.go:1195:52: undefined: any
vendor/sigs.k8s.io/json/internal/golang/encoding/json/decode.go:1261:42: undefined: any
vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:158:16: undefined: any
vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:175:22: undefined: any
vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:175:22: too many errors
note: module requires Go 1.18
FAIL	github.com/openshift/windows-machine-config-operator/test/e2e [build failed]

And I see the following in the WMCO logs:

2022-09-07T00:46:41Z	ERROR	Reconciler error	{"controller": "configmap", "controllerGroup": "", "controllerKind": "ConfigMap", "configMap": {"name":"windows-services-6.0.0-5c7656d-dirty","namespace":"openshift-windows-machine-config-operator"}, "namespace": "openshift-windows-machine-config-operator", "name": "windows-services-6.0.0-5c7656d-dirty", "reconcileID": "a57cc698-67cd-4f60-9a35-424dabe33b9e", "error": "unable to create signer from private key secret: Secret \"cloud-private-key\" not found", "errorVerbose": "Secret \"cloud-private-key\" not found\nunable to create signer from private key secret\ngithub.com/openshift/windows-machine-config-operator/controllers.(*ConfigMapReconciler).Reconcile\n\t/build/windows-machine-config-operator/controllers/configmap_controller.go:134\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/build/windows-machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:121\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/build/windows-machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:320\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/build/windows-machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:273\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/build/windows-machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:234\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1571"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/build/windows-machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:273
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/build/windows-machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:234

which implies the cloud-private-key never got created. This is very puzzling. I am not able to reproduce on my dev vSphere cluster.

aravindhp · 2022-09-07T21:13:23Z

/test vsphere-e2e-operator

aravindhp · 2022-09-09T19:04:34Z

Blocked by openshift/release#31573

aravindhp · 2022-09-09T20:12:03Z

openshift/release#31573 was superseded by openshift/release#32173 but that did not fix the WMCO repo. I have opened openshift/release#32176

aravindhp · 2022-09-09T23:06:50Z

/test vsphere-e2e-operator

Checking what go version prints.

aravindhp · 2022-09-12T14:59:00Z

/test vsphere-e2e-operator

aravindhp · 2022-09-12T23:56:14Z

/cherry-pick community-4.11

aravindhp · 2022-09-13T15:02:27Z

/retest-required

openshift-ci · 2022-09-13T15:35:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sebsoto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

aravindhp · 2022-09-13T19:35:50Z

/retest-required

aws-e2e-upgrade went past the 4 hr window for tests to complete

aravindhp · 2022-09-13T22:46:29Z

Seeing the following failure:

 === RUN   TestWMCO/create/Services_ConfigMap_validation/Invalid_services_ConfigMap_deletion
    validation_test.go:517: 
        	Error Trace:	validation_test.go:517
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestWMCO/create/Services_ConfigMap_validation/Invalid_services_ConfigMap_deletion
        	Messages:   	error testing handling of invalid ConfigMap

The log also has throttling warning:

I0913 22:11:14.791018   11634 request.go:601] Waited for 1.650274931s due to client-side throttling, not priority and fairness, request: GET:https://api.ci-op-qw7c4x3w-4bc28.origin-ci-int-aws.dev.rhcloud.com:6443/apis/autoscaling.openshift.io/v1beta1?timeout=32s

It is possible that's the reason for the time out.

/retest-required

mansikulkarni96 · 2022-09-14T14:26:32Z

Thanks for fixing this @aravindhp
/lgtm

alinaryan · 2022-09-14T16:06:17Z

thanks Aravindh!
/lgtm

openshift-ci-robot · 2022-09-14T17:04:04Z

/retest-required

Remaining retests: 0 against base HEAD 7ae5e7f and 2 for PR HEAD bff10b4 in total

aravindhp · 2022-09-14T19:16:26Z

/test vsphere-e2e-operator

Opened WINC-887 to track vsphere-e2e failing with unable to change default shell of machine

aravindhp · 2022-09-14T19:30:47Z

/override ci/prow/azure-e2e-operator

The bug is agnostic to a provider and we are seeing Azure issues in the installer.

openshift-ci · 2022-09-14T19:30:54Z

@aravindhp: Overrode contexts on behalf of aravindhp: ci/prow/azure-e2e-operator

Details

In response to this:

/override ci/prow/azure-e2e-operator

The bug is agnostic to a provider

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aravindhp · 2022-09-14T20:02:04Z

/test vsphere-e2e-operator

Not sure what the failure actually is

 Writing manifest to image destination
Storing signatures
time="2022-09-14T19:35:10Z" level=info msg="Not using native diff for overlay, this may cause degraded performance for building images: kernel has CONFIG_OVERLAY_FS_REDIRECT_DIR enabled"
I0914 19:35:10.452629       1 defaults.go:102] Defaulting to storage driver "overlay" with options [mountopt=metacopy=on].
Caching blobs under "/var/cache/blobs".
Pulling image image-registry.openshift-image-registry.svc:5000/ci-op-qr2immij/pipeline@sha256:f65d3a5dbcfdc5794b7f79b2bda6807f4031f3d978d2bf4fbc89f7ba673c23e9 ...
Trying to pull image-registry.openshift-image-registry.svc:5000/ci-op-qr2immij/pipeline@sha256:f65d3a5dbcfdc5794b7f79b2bda6807f4031f3d978d2bf4fbc89f7ba673c23e9...
Getting image source signatures
Copying blob sha256:028c90921d85568d97ca341b5433f597252a949b5c8189469e7da168e22c2a04
Copying blob sha256:2d473b07cdd5f0912cd6f1a703352c82b512407db6b05b43f2553732b55df3bc
Copying config sha256:d300066e042ebb9261f719e85e81aca869ed8296d974df3898a0e5b468b6c88e
Writing manifest to image destination
Storing signatures
Adding transient rw bind mount for /run/secrets/rhsm
[1/2] STEP 1/58: FROM image-registry.openshift-image-registry.svc:5000/ci-op-qr2immij/pipeline@sha256:f65d3a5dbcfdc5794b7f79b2bda6807f4031f3d978d2bf4fbc89f7ba673c23e9 AS build
Trying to pull image-registry.openshift-image-registry.svc:5000/ci-op-qr2immij/pipeline@sha256:f65d3a5dbcfdc5794b7f79b2bda6807f4031f3d978d2bf4fbc89f7ba673c23e9...
INFO[2022-09-14T19:35:24Z] Ran for 14m13s                               
ERRO[2022-09-14T19:35:24Z] Some steps failed:                           
ERRO[2022-09-14T19:35:24Z] 
  * could not run steps: step windows-machine-config-operator-test failed: the build windows-machine-config-operator-test failed after 2m50s with reason DockerBuildFailed: Dockerfile build strategy has failed. 
INFO[2022-09-14T19:35:24Z] Reporting job state 'failed' with reason 'executing_graph:step_failed:building_project_image'

openshift-ci · 2022-09-14T22:32:01Z

@aravindhp: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-09-14T22:36:16Z

@aravindhp: All pull requests linked via external trackers have merged:

openshift/windows-machine-config-operator#1231

Bugzilla bug 2067890 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2067890: Update prometheus-operator/pkg/client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-09-14T22:37:03Z

@aravindhp: #1231 failed to apply on top of branch "release-4.11":

Applying: Bug 2067890: Update prometheus-operator/pkg/client
.git/rebase-apply/patch:2034: trailing whitespace.
	  callback mechanism which is called when a simple domain match fails. 
.git/rebase-apply/patch:2119: trailing whitespace.
v2.11.0 
.git/rebase-apply/patch:2204: trailing whitespace.
[Full API of a UserResource](https://github.com/emicklei/go-restful/blob/v3/examples/user-resource/restful-user-resource.go) 
.git/rebase-apply/patch:2226: trailing whitespace.
- Use [jsoniter](https://github.com/json-iterator/go) by build this package using a tag, e.g. `go build -tags=jsoniter .` 
warning: 4 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	go.mod
Falling back to patching base and 3-way merge...
Removing vendor/golang.org/x/text/width/width.go
Removing vendor/golang.org/x/text/width/trieval.go
Removing vendor/golang.org/x/text/width/transform.go
Removing vendor/golang.org/x/text/width/tables9.0.0.go
Removing vendor/golang.org/x/text/width/tables13.0.0.go
Removing vendor/golang.org/x/text/width/tables12.0.0.go
Removing vendor/golang.org/x/text/width/tables11.0.0.go
Removing vendor/golang.org/x/text/width/tables10.0.0.go
Removing vendor/golang.org/x/text/width/kind_string.go
Removing vendor/golang.org/x/sys/unix/errors_freebsd_arm64.go
Removing vendor/golang.org/x/sys/unix/errors_freebsd_arm.go
Removing vendor/golang.org/x/sys/unix/errors_freebsd_amd64.go
Removing vendor/golang.org/x/sys/unix/errors_freebsd_386.go
Removing vendor/github.com/google/go-cmp/cmp/internal/flags/toolchain_recent.go
Removing vendor/github.com/google/go-cmp/cmp/internal/flags/toolchain_legacy.go
Removing vendor/github.com/go-openapi/swag/.travis.yml
Removing vendor/github.com/emicklei/go-restful/Makefile
Removing vendor/github.com/emicklei/go-restful/.travis.yml
Removing vendor/github.com/PuerkitoBio/urlesc/urlesc.go
Removing vendor/github.com/PuerkitoBio/urlesc/README.md
Removing vendor/github.com/PuerkitoBio/urlesc/LICENSE
Removing vendor/github.com/PuerkitoBio/urlesc/.travis.yml
Removing vendor/github.com/PuerkitoBio/purell/purell.go
Removing vendor/github.com/PuerkitoBio/purell/README.md
Removing vendor/github.com/PuerkitoBio/purell/LICENSE
Removing vendor/github.com/PuerkitoBio/purell/.travis.yml
Removing vendor/github.com/PuerkitoBio/purell/.gitignore
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 2067890: Update prometheus-operator/pkg/client
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-09-14T22:37:43Z

@aravindhp: new pull request created: #1256

Details

In response to this:

/cherry-pick community-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aravindhp · 2022-09-14T22:45:53Z

@aravindhp: #1231 failed to apply on top of branch "release-4.11":

Waiting on #1255 before opening manual backport

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2022

openshift-ci Bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 1, 2022

openshift-ci Bot requested a review from rrasouli September 1, 2022 22:59

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2022

openshift-ci Bot requested a review from a team September 1, 2022 23:00

openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2022

saifshaikh48 reviewed Sep 2, 2022

View reviewed changes

openshift-ci Bot assigned saifshaikh48 Sep 2, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022

aravindhp marked this pull request as ready for review September 6, 2022 22:33

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2022

openshift-ci Bot requested review from mansikulkarni96 and sebsoto September 6, 2022 22:34

Bug 2067890: Update prometheus-operator/pkg/client

bff10b4

Ran: go get -u github.com/prometheus-operator/prometheus-operator/pkg/client go mod tidy go mod vendor go mod verify Fixes BZ#2067890

aravindhp marked this pull request as draft September 8, 2022 22:09

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2022

aravindhp force-pushed the bug-2067890 branch from a879c15 to 5de1bb1 Compare September 9, 2022 23:06

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2022

aravindhp marked this pull request as draft September 13, 2022 15:05

aravindhp marked this pull request as ready for review September 13, 2022 15:05

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2022

aravindhp force-pushed the bug-2067890 branch from 5de1bb1 to bff10b4 Compare September 13, 2022 15:09

sebsoto approved these changes Sep 13, 2022

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2022

openshift-ci Bot assigned mansikulkarni96 Sep 14, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022

openshift-ci Bot assigned alinaryan Sep 14, 2022

openshift-merge-robot merged commit 2f359e3 into openshift:master Sep 14, 2022

openshift-cherrypick-robot mentioned this pull request Sep 14, 2022

[community-4.11] Update prometheus-operator/pkg/client #1256

Merged

aravindhp deleted the bug-2067890 branch September 14, 2022 22:47

aravindhp mentioned this pull request Sep 14, 2022

[release-4.11] OCPBUGS-1345: Update prometheus-operator/pkg/client #1257

Merged

Conversation

aravindhp commented Sep 1, 2022

Uh oh!

openshift-ci Bot commented Sep 1, 2022

Uh oh!

openshift-ci Bot commented Sep 1, 2022

Uh oh!

aravindhp commented Sep 1, 2022

Uh oh!

aravindhp commented Sep 1, 2022

Uh oh!

openshift-cherrypick-robot commented Sep 1, 2022

Uh oh!

saifshaikh48 left a comment

Choose a reason for hiding this comment

Uh oh!

aravindhp commented Sep 7, 2022

Uh oh!

aravindhp commented Sep 7, 2022

Uh oh!

aravindhp commented Sep 9, 2022

Uh oh!

aravindhp commented Sep 9, 2022

Uh oh!

aravindhp commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aravindhp commented Sep 12, 2022

Uh oh!

aravindhp commented Sep 12, 2022

Uh oh!

aravindhp commented Sep 13, 2022

Uh oh!

openshift-ci Bot commented Sep 13, 2022

Uh oh!

aravindhp commented Sep 13, 2022

Uh oh!

aravindhp commented Sep 13, 2022

Uh oh!

mansikulkarni96 commented Sep 14, 2022

Uh oh!

alinaryan commented Sep 14, 2022

Uh oh!

openshift-ci-robot commented Sep 14, 2022

Uh oh!

aravindhp commented Sep 14, 2022 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aravindhp commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Sep 14, 2022

Uh oh!

aravindhp commented Sep 14, 2022

Uh oh!

openshift-ci Bot commented Sep 14, 2022

Uh oh!

openshift-ci Bot commented Sep 14, 2022

Uh oh!

openshift-cherrypick-robot commented Sep 14, 2022

Uh oh!

openshift-cherrypick-robot commented Sep 14, 2022

Uh oh!

aravindhp commented Sep 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

aravindhp commented Sep 9, 2022 •

edited

Loading

aravindhp commented Sep 14, 2022 •

edited by openshift-ci Bot

Loading

aravindhp commented Sep 14, 2022 •

edited

Loading