ci-operator/step-registry: Trim wking from various OWNERS#32997
Merged
openshift-merge-robot merged 1 commit intoOct 12, 2022
Merged
Conversation
openshift-ci
Bot
added
the
approved
wking
changed the title
I was on the installer team back when I was added to a number of these directories. But I've now been on the updates team for long enough that I'm no longer current with install/deprovision mechanics. This commit removes me from a number of locations where I don't consider myself a subject-matter expert, hopefully making it easier for folks to actually find a knowledgeable approver for their changes. I'm leaving myself as an approver in a few places (e.g. proxy steps) where I don't consider myself a subject-matter expert, to avoid completely emptying the approver step. I'll come back in follow-up work to try to address those, either by finding additional approvers, or by removing those steps altogether.
wking
force-pushed
the
trim-wking-ci-operator-step-registry-ownership
branch
from
3330197 to
7c7677c
Compare
Member
Author
|
Proximal trigger is me trying to back out of ipi-install-install maintenance/approval for #31965. I don't want to trigger another reroll there, so holding this metadata shift until that one lands: /hold |
openshift-ci
Bot
added
the
do-not-merge/hold
Contributor
|
/lgtm |
Contributor
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
Member
Author
|
#31965 landed. /hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
Contributor
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
May 19, 2023
Following up on aeb4b72 (ci-operator/step-registry: Trim wking from various OWNERS, 2022-10-12, openshift#32997), now that f680c2c (Add stbenjam to proxy step owners, 2023-05-19, openshift#38450) has Stephen stepping up as a replacement (and he has also agreed to take over the other proxy steps and chains I'm adjusting in this commit). Thanks!
openshift-merge-robot
pushed a commit
that referenced
this pull request
May 21, 2023
Following up on aeb4b72 (ci-operator/step-registry: Trim wking from various OWNERS, 2022-10-12, #32997), now that f680c2c (Add stbenjam to proxy step owners, 2023-05-19, #38450) has Stephen stepping up as a replacement (and he has also agreed to take over the other proxy steps and chains I'm adjusting in this commit). Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was on the installer team back when I was added to a number of these directories. But I've now been on the updates team for long enough that I'm no longer current with install/deprovision mechanics. This commit removes me from a number of locations where I don't consider myself a subject-matter expert, hopefully making it easier for folks to actually find a knowledgeable approver for their changes.
I'm leaving myself as an approver in a few places (e.g. proxy steps) where I don't consider myself a subject-matter expert, to avoid completely emptying the approver step. I'll come back in follow-up work to try to address those, either by finding additional approvers, or by removing those steps altogether.