Skip to content

ci-operator/step-registry: Trim wking from proxy OWNERS#39521

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
wking:drop-wking-as-proxy-approver
May 21, 2023
Merged

ci-operator/step-registry: Trim wking from proxy OWNERS#39521
openshift-merge-robot merged 1 commit into
openshift:masterfrom
wking:drop-wking-as-proxy-approver

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented May 19, 2023

Following up on aeb4b72 (#32997), now that f680c2c (#38450) has @stbenjam stepping up as a replacement (and he has also agreed to take over the other proxy steps and chains I'm adjusting in this commit). Thanks!

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 19, 2023
@openshift-ci openshift-ci Bot requested review from DennisPeriquet and neisw May 19, 2023 16:00
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2023
Following up on aeb4b72 (ci-operator/step-registry: Trim wking from
various OWNERS, 2022-10-12, openshift#32997), now that f680c2c (Add stbenjam
to proxy step owners, 2023-05-19, openshift#38450) has Stephen stepping up as a
replacement (and he has also agreed to take over the other proxy steps
and chains I'm adjusting in this commit).  Thanks!
@wking wking force-pushed the drop-wking-as-proxy-approver branch from d59e033 to a145b44 Compare May 19, 2023 16:51
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@wking: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@stbenjam
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2023

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 590d0ff into openshift:master May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants