Skip to content

Add etcd-scaling test presubmits #34552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 7, 2022
Merged

Add etcd-scaling test presubmits #34552

openshift-merge-robot merged 1 commit into from
Dec 7, 2022

Conversation

@hasbro17
Copy link
Contributor

@hasbro17 hasbro17 commented Dec 5, 2022

Adds the presubmits to run the etcd-scaling test suite on origin PRs so we can test the changes to the scaling suite itself.

Required to test changes in openshift/origin#27497

/cc @xueqzhan @stbenjam

@hasbro17
Add etcd-scaling test presubmits
17d3551 
Adds the presubmits to run the etcd-scaling test suite on origin PRs
so we can test the changes to the scaling suite itself
@openshift-ci openshift-ci bot requested review from stbenjam and xueqzhan December 5, 2022 20:25
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 5, 2022

@hasbro17: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-master-e2e-aws-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-master-e2e-azure-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-master-e2e-gcp-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-master-e2e-vsphere-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.12-e2e-aws-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.12-e2e-azure-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.12-e2e-gcp-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.12-e2e-vsphere-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.13-e2e-aws-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.13-e2e-azure-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.13-e2e-gcp-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.13-e2e-vsphere-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.14-e2e-aws-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.14-e2e-azure-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.14-e2e-gcp-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.14-e2e-vsphere-ovn-etcd-scaling openshift/origin presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@hasbro17
Copy link
Contributor Author

hasbro17 commented Dec 5, 2022

/pj-rehearse

There are known issues of the "events should not repeat pathologically" type on non-aws platforms, although this is just to add the optional presubmits so it shouldn't affect any required CI jobs on origin.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022

@hasbro17: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/origin/release-4.13/e2e-aws-ovn-etcd-scaling 17d3551 link unknown /pj-rehearse
ci/rehearse/openshift/origin/release-4.13/e2e-azure-ovn-etcd-scaling 17d3551 link unknown /pj-rehearse
ci/rehearse/openshift/origin/release-4.12/e2e-gcp-ovn-etcd-scaling 17d3551 link unknown /pj-rehearse
ci/rehearse/openshift/origin/release-4.12/e2e-vsphere-ovn-etcd-scaling 17d3551 link unknown /pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xueqzhan
Copy link
Contributor

xueqzhan commented Dec 6, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
@stbenjam
Copy link
Member

stbenjam commented Dec 6, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasbro17, stbenjam, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2022
@hasbro17
Copy link
Contributor Author

hasbro17 commented Dec 6, 2022

@stbenjam Can you please tag the rehearsals-ack label?

The test itself is running fine and failures are from things like events repeating or KubeAPIErrorBudgetBurn.

@hasbro17
Copy link
Contributor Author

hasbro17 commented Dec 7, 2022

/label rehearsals-ack

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2022

@hasbro17: The label(s) /label rehearsals-ack cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label rehearsals-ack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hasbro17
Copy link
Contributor Author

hasbro17 commented Dec 7, 2022

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit 540a7c4 into openshift:master Dec 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2022

@hasbro17: Updated the following 8 configmaps:

  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-master-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-master-presubmits.yaml
  • job-config-4.12 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-release-4.12-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-release-4.12-presubmits.yaml
  • job-config-4.13 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-release-4.13-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-release-4.13-presubmits.yaml
  • job-config-4.14 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-release-4.14-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-release-4.14-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-master.yaml using file ci-operator/config/openshift/origin/openshift-origin-master.yaml
  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-release-4.12.yaml using file ci-operator/config/openshift/origin/openshift-origin-release-4.12.yaml
  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-release-4.13.yaml using file ci-operator/config/openshift/origin/openshift-origin-release-4.13.yaml
  • ci-operator-4.14-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-release-4.14.yaml using file ci-operator/config/openshift/origin/openshift-origin-release-4.14.yaml
Details

In response to this:

Adds the presubmits to run the etcd-scaling test suite on origin PRs so we can test the changes to the scaling suite itself.

Required to test changes in openshift/origin#27497

/cc @xueqzhan @stbenjam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Elbehery Elbehery mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stbenjam stbenjam Awaiting requested review from stbenjam

@xueqzhan xueqzhan Awaiting requested review from xueqzhan

Assignees

@stbenjam stbenjam

@xueqzhan xueqzhan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hasbro17 @openshift-ci-robot @xueqzhan @stbenjam @openshift-merge-robot