Skip to content

Conversation

@Elbehery
Copy link
Contributor

Etcd vertical scaling was added in #34552

This PR make always-run as false

resolves https://issues.redhat.com/browse/OCPBUGS-13667

cc @hasbro17 @tjungblu @dusk125

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 17, 2023
@openshift-ci-robot
Copy link
Contributor

@Elbehery: This pull request references Jira Issue OCPBUGS-13667, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Etcd vertical scaling was added in #34552

This PR make always-run as false

resolves https://issues.redhat.com/browse/OCPBUGS-13667

cc @hasbro17 @tjungblu @dusk125

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Elbehery
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@Elbehery: An error was encountered querying GitHub for users with public email (geliu@redhat.com) for bug OCPBUGS-13667 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from deads2k and sjenning May 17, 2023 14:50
@Elbehery Elbehery changed the title OCPBUGS-13667: Don't always run etcd scaling jobs OCPBUGS-13667: skip always run etcd scaling jobs May 17, 2023
@hasbro17
Copy link
Contributor

/lgtm

/cc @bparees If you don't mind taking a look to approve. We're just making sure our optional etcd-scaling jobs aren't running on every PR in origin by default.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
@Elbehery
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 18, 2023
@Elbehery
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 18, 2023
@openshift-ci-robot
Copy link
Contributor

@Elbehery: This pull request references Jira Issue OCPBUGS-13667, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from geliu2016 May 18, 2023 15:18
@bparees
Copy link
Contributor

bparees commented May 18, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, Elbehery, hasbro17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2023

@Elbehery: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ad1b023 into openshift:master May 18, 2023
@openshift-ci-robot
Copy link
Contributor

@Elbehery: Jira Issue OCPBUGS-13667: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13667 has been moved to the MODIFIED state.

Details

In response to this:

Etcd vertical scaling was added in #34552

This PR make always-run as false

resolves https://issues.redhat.com/browse/OCPBUGS-13667

cc @hasbro17 @tjungblu @dusk125

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2023

@Elbehery: Updated the following 5 configmaps:

  • job-config-4.15 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-release-4.15-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-release-4.15-presubmits.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-master-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-master-presubmits.yaml
  • job-config-4.12 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-release-4.12-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-release-4.12-presubmits.yaml
  • job-config-4.13 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-release-4.13-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-release-4.13-presubmits.yaml
  • job-config-4.14 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-release-4.14-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-release-4.14-presubmits.yaml
Details

In response to this:

Etcd vertical scaling was added in #34552

This PR make always-run as false

resolves https://issues.redhat.com/browse/OCPBUGS-13667

cc @hasbro17 @tjungblu @dusk125

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants