Skip to content

OpenStack: Remove obsolete skips#34948

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
shiftstack:openstack-skip-cinder
Dec 21, 2022
Merged

OpenStack: Remove obsolete skips#34948
openshift-merge-robot merged 1 commit into
openshift:masterfrom
shiftstack:openstack-skip-cinder

Conversation

@mandre
Copy link
Copy Markdown
Member

@mandre mandre commented Dec 20, 2022

We're in the process of removing the in-tree cloud provider with the k8s 1.26 rebase, and to do so we had to skip in-tree cinder provisioner tests with openshift/origin#27613.

This caused the
periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-ovn-appcreds job to fail with:

Error: no tests were found matching the TEST_SKIPS regex:
In-tree Volumes \[Driver: cinder\]

The plan is to revert openshift/origin#27613 as soon as the 1.26 rebase lands. Drop the obsolete TEST_SKIPS for now at least until the revert is effective.

We're in the process of removing the in-tree cloud provider with the k8s
1.26 rebase, and to do so we had to skip in-tree cinder provisioner
tests with openshift/origin#27613.

This caused the
periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-ovn-appcreds
job to fail with:

    Error: no tests were found matching the TEST_SKIPS regex:
    In-tree Volumes \[Driver: cinder\]

The plan is to revert openshift/origin#27613 as
soon as the 1.26 rebase lands. Drop the obsolete TEST_SKIPS for now
at least until the revert is effective.
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mandre: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-ovn-appcreds N/A periodic Ci-operator config changed
periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mandre
Copy link
Copy Markdown
Member Author

mandre commented Dec 20, 2022

@openshift-ci openshift-ci Bot requested review from EmilienM and mdbooth December 20, 2022 16:29
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2022
@dulek
Copy link
Copy Markdown
Contributor

dulek commented Dec 20, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, mandre, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandre
Copy link
Copy Markdown
Member Author

mandre commented Dec 20, 2022

/pj-rehearse

@mandre
Copy link
Copy Markdown
Member Author

mandre commented Dec 21, 2022

The jobs failed for known, unrelated, reasons. This patch is doing what it should.
/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 21, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 21, 2022

@mandre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az d02e519 link unknown /pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az
ci/rehearse/periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-ovn-appcreds d02e519 link unknown /pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-ovn-appcreds

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ce44d6f into openshift:master Dec 21, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 21, 2022

@mandre: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key shiftstack-shiftstack-ci-main__periodic-4.13.yaml using file ci-operator/config/shiftstack/shiftstack-ci/shiftstack-shiftstack-ci-main__periodic-4.13.yaml
Details

In response to this:

We're in the process of removing the in-tree cloud provider with the k8s 1.26 rebase, and to do so we had to skip in-tree cinder provisioner tests with openshift/origin#27613.

This caused the
periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-ovn-appcreds job to fail with:

Error: no tests were found matching the TEST_SKIPS regex:
In-tree Volumes [Driver: cinder]

The plan is to revert openshift/origin#27613 as soon as the 1.26 rebase lands. Drop the obsolete TEST_SKIPS for now at least until the revert is effective.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the openstack-skip-cinder branch December 21, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants