Skip to content

OpenStack: Skip in-tree cinder provisioner tests#27613

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:skip-cinder-intree
Dec 19, 2022
Merged

OpenStack: Skip in-tree cinder provisioner tests#27613
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:skip-cinder-intree

Conversation

@mandre
Copy link
Copy Markdown
Member

@mandre mandre commented Dec 15, 2022

In preparation for kube 1.26 rebase.

@openshift-ci openshift-ci Bot requested review from bthurber and mfojtik December 15, 2022 16:24
Comment thread test/extended/util/annotate/rules.go
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
I've looked into openshift/kubernetes#1432 which is bringing in k8s 1.26 and several random tests I've searched for I still found there being run. So I'd suggest you to compare and see which exact tests should be skipped and only disable those.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2022
@mandre
Copy link
Copy Markdown
Member Author

mandre commented Dec 19, 2022

/hold I've looked into openshift/kubernetes#1432 which is bringing in k8s 1.26 and several random tests I've searched for I still found there being run. So I'd suggest you to compare and see which exact tests should be skipped and only disable those.

Yeah, I've missed kubernetes/kubernetes#113826 which brings back many of the tests that kubernetes/kubernetes#67782 removed. However we can't really fine-tune the list of tests to skip more than what we're already doing because these tests can't pass until we land the 1.26 rebase.

So in order to not have the openstack job permafailing till the 1.26 rebase, the correct way to go would be to:

Now if I understand @jsafrane's request correctly, he's asking for a jira to track re-enabling the tests which indeed seems like the right thing to do.

I'll create a Jira and update this patch to reference it.

In preparation for kube 1.26 rebase.
@mandre mandre force-pushed the skip-cinder-intree branch from 0efa31f to 43284bb Compare December 19, 2022 15:30
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2022
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit e01044b into openshift:master Dec 19, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 19, 2022

@mandre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-etcd-scaling 43284bb link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-etcd-scaling 43284bb link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-etcd-scaling 43284bb link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-single-node-serial 43284bb link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mandre added a commit to shiftstack/release that referenced this pull request Dec 20, 2022
We're in the process of removing the in-tree cloud provider with the k8s
1.26 rebase, and to do so we had to skip in-tree cinder provisioner
tests with openshift/origin#27613.

This caused the
periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-ovn-appcreds
job to fail with:

    Error: no tests were found matching the TEST_SKIPS regex:
    In-tree Volumes \[Driver: cinder\]

The plan is to revert openshift/origin#27613 as
soon as the 1.26 rebase lands. Drop the obsolete TEST_SKIPS for now
at least until the revert is effective.
openshift-merge-robot pushed a commit to openshift/release that referenced this pull request Dec 21, 2022
We're in the process of removing the in-tree cloud provider with the k8s
1.26 rebase, and to do so we had to skip in-tree cinder provisioner
tests with openshift/origin#27613.

This caused the
periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-ovn-appcreds
job to fail with:

    Error: no tests were found matching the TEST_SKIPS regex:
    In-tree Volumes \[Driver: cinder\]

The plan is to revert openshift/origin#27613 as
soon as the 1.26 rebase lands. Drop the obsolete TEST_SKIPS for now
at least until the revert is effective.
@pierreprinetti pierreprinetti deleted the skip-cinder-intree branch June 9, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants