OpenStack: Skip in-tree cinder provisioner tests#27613
OpenStack: Skip in-tree cinder provisioner tests#27613openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
soltysh
left a comment
There was a problem hiding this comment.
/hold
I've looked into openshift/kubernetes#1432 which is bringing in k8s 1.26 and several random tests I've searched for I still found there being run. So I'd suggest you to compare and see which exact tests should be skipped and only disable those.
Yeah, I've missed kubernetes/kubernetes#113826 which brings back many of the tests that kubernetes/kubernetes#67782 removed. However we can't really fine-tune the list of tests to skip more than what we're already doing because these tests can't pass until we land the 1.26 rebase. So in order to not have the openstack job permafailing till the 1.26 rebase, the correct way to go would be to:
Now if I understand @jsafrane's request correctly, he's asking for a jira to track re-enabling the tests which indeed seems like the right thing to do. I'll create a Jira and update this patch to reference it. |
In preparation for kube 1.26 rebase.
0efa31f to
43284bb
Compare
soltysh
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/hold cancel
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mandre: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
We're in the process of removing the in-tree cloud provider with the k8s 1.26 rebase, and to do so we had to skip in-tree cinder provisioner tests with openshift/origin#27613. This caused the periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-ovn-appcreds job to fail with: Error: no tests were found matching the TEST_SKIPS regex: In-tree Volumes \[Driver: cinder\] The plan is to revert openshift/origin#27613 as soon as the 1.26 rebase lands. Drop the obsolete TEST_SKIPS for now at least until the revert is effective.
We're in the process of removing the in-tree cloud provider with the k8s 1.26 rebase, and to do so we had to skip in-tree cinder provisioner tests with openshift/origin#27613. This caused the periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-ovn-appcreds job to fail with: Error: no tests were found matching the TEST_SKIPS regex: In-tree Volumes \[Driver: cinder\] The plan is to revert openshift/origin#27613 as soon as the 1.26 rebase lands. Drop the obsolete TEST_SKIPS for now at least until the revert is effective.
In preparation for kube 1.26 rebase.