Skip to content

Initial config for prow jobs for openstack-baremetal-operator #37013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 14, 2023
Merged

Initial config for prow jobs for openstack-baremetal-operator #37013

openshift-merge-robot merged 1 commit into from
Mar 14, 2023

Conversation

@marios
Copy link
Contributor

@marios marios commented Mar 7, 2023

See related pull request at [1]

[1] openstack-k8s-operators/openstack-baremetal-operator#3

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 7, 2023

@marios: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-main-gofmt openstack-k8s-operators/openstack-baremetal-operator presubmit Presubmit changed
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-main-golangci openstack-k8s-operators/openstack-baremetal-operator presubmit Presubmit changed
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-main-golint openstack-k8s-operators/openstack-baremetal-operator presubmit Presubmit changed
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-main-govet openstack-k8s-operators/openstack-baremetal-operator presubmit Presubmit changed
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-main-images openstack-k8s-operators/openstack-baremetal-operator presubmit Presubmit changed
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-main-precommit-check openstack-k8s-operators/openstack-baremetal-operator presubmit Presubmit changed
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-main-unit openstack-k8s-operators/openstack-baremetal-operator presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from bear-redhat and hongkailiu March 7, 2023 11:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2023
@marios marios marked this pull request as draft March 7, 2023 11:32
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2023
viroel
viroel suggested changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@viroel viroel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the master x main names are causing error on ci jobs.

@marios marios force-pushed the openstack-baremetal-operator-prow-onboarding branch from 1f719dd to 19ad875 Compare March 8, 2023 14:04
@marios marios force-pushed the openstack-baremetal-operator-prow-onboarding branch from 19ad875 to 787364a Compare March 9, 2023 12:25
@marios
Copy link
Contributor Author

marios commented Mar 9, 2023

/pj-rehearse

@marios marios marked this pull request as ready for review March 9, 2023 12:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2023
@openshift-ci openshift-ci bot requested a review from droslean March 9, 2023 12:38
@marios marios requested review from viroel and removed request for bear-redhat, droslean and hongkailiu March 9, 2023 12:53
@marios
Copy link
Contributor Author

marios commented Mar 10, 2023

@viroel i posted * openstack-k8s-operators/openstack-baremetal-operator#4
* Fixes some precommit issues indendation and +x for shebang files #4

to fix the issue in precommit job seen here https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/37013/rehearse-37013-pull-ci-openstack-k8s-operators-openstack-baremetal-operator-master-precommit-check/1633809688766189568/build-log.txt

@viroel
Copy link
Contributor

viroel commented Mar 10, 2023

/pj-rehearse pull-ci-openstack-k8s-operators-openstack-baremetal-operator-master-precommit-check

@viroel
Copy link
Contributor

viroel commented Mar 10, 2023

/pj-rehearse ack

openstack-k8s-operators/openstack-baremetal-operator#4 merged.
pre-commit job is now passing

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 10, 2023
@viroel
Copy link
Contributor

viroel commented Mar 10, 2023

/lgtm thanks marios

@marios
Copy link
Contributor Author

marios commented Mar 13, 2023

@viroel @Sandeepyadav93 who else do we assign this to for merge? For the pending tide run... we need another lgtm? or i am reading that wrong?

@Sandeepyadav93
Copy link
Contributor

Sandeepyadav93 commented Mar 13, 2023

looks good, but we need /lgtm label from someone in the OWNERS file

[1] https://github.com/openshift/release/pull/37013/files#diff-5263616e7515e5f62bfd5c7b08d835d690a3fc92ad5d205ea559805582b933d6

@Sandeepyadav93
Copy link
Contributor

Sandeepyadav93 commented Mar 13, 2023

/assign @dprince

@marios
Copy link
Contributor Author

marios commented Mar 14, 2023

@abays can you please have a look at this when you have some time

abays
abays approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm as far as I understand these bits :)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, marios, viroel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

@marios: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 45096fa into openshift:master Mar 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

@marios: Updated the following 4 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openstack-k8s-operators-openstack-baremetal-operator-master.yaml using file ci-operator/config/openstack-k8s-operators/openstack-baremetal-operator/openstack-k8s-operators-openstack-baremetal-operator-master.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openstack-k8s-operators-openstack-baremetal-operator-master-presubmits.yaml using file ci-operator/jobs/openstack-k8s-operators/openstack-baremetal-operator/openstack-k8s-operators-openstack-baremetal-operator-master-presubmits.yaml
  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openstack-k8s-operators-openstack-baremetal-operator-_pluginconfig.yaml using file core-services/prow/02_config/openstack-k8s-operators/openstack-baremetal-operator/_pluginconfig.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openstack-k8s-operators-openstack-baremetal-operator-_prowconfig.yaml using file core-services/prow/02_config/openstack-k8s-operators/openstack-baremetal-operator/_prowconfig.yaml
Details

In response to this:

See related pull request at [1]

[1] openstack-k8s-operators/openstack-baremetal-operator#3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

marios added a commit to marios/release that referenced this pull request Mar 14, 2023
@marios
Adds openstack-baremetal-operator-build-deploy job for e2e test
afcb807 
The initial config and pre-commit test was merged with [1]. This
adds the end to end build-deploy job.

[1] openshift#37013
@marios marios mentioned this pull request Mar 14, 2023
Closed
bmanzari pushed a commit to bmanzari/release that referenced this pull request Mar 30, 2023
@marios @bmanzari
Initial config for prow jobs for openstack-baremetal-operator (opensh…
e989a13 
…ift#37013)

See related pull request at [1]

[1] openstack-k8s-operators/openstack-baremetal-operator#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viroel viroel Awaiting requested review from viroel

1 more reviewer

@abays abays abays approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dprince dprince

@abays abays

@viroel viroel

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@marios @openshift-ci-robot @viroel @Sandeepyadav93 @abays @dprince @openshift-merge-robot