Skip to content

Adds openstack-baremetal-operator-build-deploy job for e2e test #37291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marios wants to merge 1 commit into from
Closed

Adds openstack-baremetal-operator-build-deploy job for e2e test #37291

marios wants to merge 1 commit into from

Conversation

@marios
Copy link
Contributor

@marios marios commented Mar 14, 2023

The initial config and pre-commit test was merged with [1]. This adds the end to end build-deploy job.

[1] #37013

@marios
Adds openstack-baremetal-operator-build-deploy job for e2e test
afcb807 
The initial config and pre-commit test was merged with [1]. This
adds the end to end build-deploy job.

[1] openshift#37013
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 14, 2023

@marios: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-master-openstack-baremetal-operator-build-deploy openstack-k8s-operators/openstack-baremetal-operator presubmit Presubmit changed
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-master-images openstack-k8s-operators/openstack-baremetal-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-master-precommit-check openstack-k8s-operators/openstack-baremetal-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-master-unit openstack-k8s-operators/openstack-baremetal-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@marios
Copy link
Contributor Author

marios commented Mar 14, 2023

@viroel @Sandeepyadav93 please check when you have some time o/ thank you!

@openshift-ci openshift-ci bot requested review from dprince and olliewalsh March 14, 2023 16:32
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marios
Once this PR has been reviewed and has the lgtm label, please assign dprince for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dasm
Copy link

dasm commented Mar 14, 2023

LGTM

@rlandy
Copy link
Contributor

rlandy commented Mar 14, 2023

/pj-rehearse pull-ci-openstack-k8s-operators-openstack-baremetal-operator-master-openstack-baremetal-operator-build-deploy

@viroel
Copy link
Contributor

viroel commented Mar 14, 2023

/pj-rehearse pull-ci-openstack-k8s-operators-openstack-baremetal-operator-master-openstack-baremetal-operator-build-deploy

repos are now public

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

@marios: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlandy
Copy link
Contributor

rlandy commented Mar 15, 2023

lgtm now - waiting on core to merge this

@marios
Copy link
Contributor Author

marios commented Mar 15, 2023

@abays please add this to your list for reviews whenever you next have time thank you

(followup from #37013 which you merged yesterday )

@marios marios marked this pull request as draft March 15, 2023 11:48
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2023
@marios
Copy link
Contributor Author

marios commented Mar 15, 2023

discussing now with @viroel @rlandy @Sandeepyadav93 and converting to draft

we need to add support in the meta operator first

@marios
Copy link
Contributor Author

marios commented Mar 16, 2023

Discussed this a bit with @abays just now. We will need a different job for the baremetal end-to-end testing and we will (likely) not be integrating with the openstack-operator.

Dropping this pull request for now then.

@marios marios closed this Mar 16, 2023
@marios marios mentioned this pull request Mar 20, 2023
Merged
marios added a commit to marios/release that referenced this pull request Mar 21, 2023
@marios
Add openstack-baremetal-operator container image build job
52fd833 
This adds a image build job for the openstack-baremetal-operator
As discussed at [1] we cannot have a build-deploy job so this
can at least provide some coverage for the image build.

[1] openshift#37291 (comment)
openshift-merge-robot pushed a commit that referenced this pull request Mar 22, 2023
@marios
Add openstack-baremetal-operator container image build job (#37492)
1944183 
This adds a image build job for the openstack-baremetal-operator
As discussed at [1] we cannot have a build-deploy job so this
can at least provide some coverage for the image build.

[1] #37291 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprince dprince Awaiting requested review from dprince

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marios @openshift-ci-robot @dasm @rlandy @viroel