Skip to content

Conversation

@marios
Copy link
Contributor

@marios marios commented Mar 20, 2023

This adds a image build job for the openstack-baremetal-operator As discussed at [1] we cannot have a build-deploy job so this can at least provide some coverage for the image build.

[1] #37291 (comment)

@marios marios marked this pull request as draft March 20, 2023 17:03
@openshift-ci-robot
Copy link
Contributor

@marios: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-master-openstack-baremetal-operator-build openstack-k8s-operators/openstack-baremetal-operator presubmit Presubmit changed
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-master-images openstack-k8s-operators/openstack-baremetal-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-master-precommit-check openstack-k8s-operators/openstack-baremetal-operator presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-master-unit openstack-k8s-operators/openstack-baremetal-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@marios
Copy link
Contributor Author

marios commented Mar 20, 2023

@viroel @Sandeepyadav93 grateful for initial sanity check when you next have time for reviews please o/ thank you!

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2023
@openshift-ci openshift-ci bot requested review from dprince and olliewalsh March 20, 2023 17:05
@marios
Copy link
Contributor Author

marios commented Mar 21, 2023

/pj-rehearse

@marios
Copy link
Contributor Author

marios commented Mar 21, 2023

This adds a image build job for the openstack-baremetal-operator
As discussed at [1] we cannot have a build-deploy job so this
can at least provide some coverage for the image build.

[1] openshift#37291 (comment)
@marios marios force-pushed the openstack-baremetal-operator-build-job branch from fb3492b to 52fd833 Compare March 21, 2023 15:15
@marios
Copy link
Contributor Author

marios commented Mar 21, 2023

/pj-rehearse

@marios marios marked this pull request as ready for review March 21, 2023 15:56
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2023
@openshift-ci openshift-ci bot requested review from abays and stuggi March 21, 2023 16:00
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 22, 2023
@Sandeepyadav93
Copy link
Contributor

/lgtm

I am not in owners file, so will need vote from someone in owners file.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2023
Copy link
Member

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, marios, Sandeepyadav93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

@marios: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1944183 into openshift:master Mar 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

@marios: Updated the following 2 configmaps:

  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openstack-k8s-operators-openstack-baremetal-operator-master-presubmits.yaml using file ci-operator/jobs/openstack-k8s-operators/openstack-baremetal-operator/openstack-k8s-operators-openstack-baremetal-operator-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openstack-k8s-operators-openstack-baremetal-operator-master.yaml using file ci-operator/config/openstack-k8s-operators/openstack-baremetal-operator/openstack-k8s-operators-openstack-baremetal-operator-master.yaml
Details

In response to this:

This adds a image build job for the openstack-baremetal-operator As discussed at [1] we cannot have a build-deploy job so this can at least provide some coverage for the image build.

[1] #37291 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants