-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add openstack-baremetal-operator container image build job #37492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openstack-baremetal-operator container image build job #37492
Conversation
|
@marios: the
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@viroel @Sandeepyadav93 grateful for initial sanity check when you next have time for reviews please o/ thank you! |
|
/pj-rehearse |
|
forgot to add the base_images (cli: and opm-builder:) updating with force push momentarily |
This adds a image build job for the openstack-baremetal-operator As discussed at [1] we cannot have a build-deploy job so this can at least provide some coverage for the image build. [1] openshift#37291 (comment)
fb3492b to
52fd833
Compare
|
/pj-rehearse |
...penstack-baremetal-operator/openstack-k8s-operators-openstack-baremetal-operator-master.yaml
Show resolved
Hide resolved
|
/pj-rehearse ack We are only adding container build job for now, results looks good |
|
/lgtm I am not in owners file, so will need vote from someone in owners file. |
abays
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, marios, Sandeepyadav93 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@marios: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@marios: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This adds a image build job for the openstack-baremetal-operator As discussed at [1] we cannot have a build-deploy job so this can at least provide some coverage for the image build.
[1] #37291 (comment)