MicroShift - set golangci-lint explicitly by copejon · Pull Request #38194 · openshift/release

copejon · 2023-04-10T16:25:55Z

Golangci-lint cannot access the default directory to create the .cache subdir because the home dir does not exist. Specify the cache dir under /tmp to workaround this.

Unblocks openshift/microshift#1605

openshift-ci-robot · 2023-04-10T16:27:01Z

@copejon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-microshift-main-verify	openshift/microshift	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

copejon · 2023-04-10T16:38:20Z

/pj-rehearse

copejon · 2023-04-10T16:50:30Z

/test verify

openshift-ci · 2023-04-10T16:50:34Z

@copejon: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test app-ci-config-dry
/test boskos-config
/test boskos-config-generation
/test build-clusters
/test build01-dry
/test build02-dry
/test build03-dry
/test build04-dry
/test build05-dry
/test check-gh-automation
/test ci-operator-config
/test ci-operator-config-metadata
/test ci-operator-registry
/test ci-secret-bootstrap-config-validation
/test ci-testgrid-allow-list
/test clusterimageset-validate
/test config
/test core-valid
/test correctly-sharded-config
/test deprecate-templates
/test generated-config
/test generated-dashboards
/test hive-dry
/test jira-lifecycle-config
/test openshift-image-mirror-mappings
/test ordered-prow-config
/test owners
/test pr-reminder-config
/test prow-config
/test prow-config-filenames
/test prow-config-semantics
/test pylint
/test release-config
/test release-controller-config
/test secret-generator-config-valid
/test services-valid
/test step-registry-metadata
/test step-registry-shellcheck
/test supplemental-ci-images-mapping-files
/test sync-rover-groups
/test yamllint

The following commands are available to trigger optional jobs:

/test arm01-dry
/test vsphere-dry

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-release-check-gh-automation
pull-ci-openshift-release-master-build-clusters
pull-ci-openshift-release-master-ci-operator-config
pull-ci-openshift-release-master-ci-operator-config-metadata
pull-ci-openshift-release-master-ci-operator-registry
pull-ci-openshift-release-master-core-valid
pull-ci-openshift-release-master-correctly-sharded-config
pull-ci-openshift-release-master-deprecate-templates
pull-ci-openshift-release-master-generated-config
pull-ci-openshift-release-master-ordered-prow-config
pull-ci-openshift-release-master-owners
pull-ci-openshift-release-master-prow-config-filenames
pull-ci-openshift-release-master-release-controller-config
pull-ci-openshift-release-openshift-image-mirror-mappings
pull-ci-openshift-release-yamllint

Details

In response to this:

/test verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

copejon · 2023-04-10T18:25:38Z

/pj-rehearse

copejon · 2023-04-10T18:48:31Z

/pj-rehearse

copejon · 2023-04-10T19:30:34Z

/pj-rehearse

copejon · 2023-04-10T21:14:57Z

/pj-rehearse pull-ci-openshift-microshift-main-verify-go

copejon · 2023-04-10T21:45:07Z

/pj-rehearse pull-ci-openshift-microshift-main-verify

pacevedom

/lgtm
/hold
Holding in case you want to check the resources, I am good to look into it in a different PR.

pacevedom · 2023-04-11T12:13:09Z

+          cpu: 100m
+          memory: 200Mi


My only nit, is this enough for good scheduling? We can always check after a few executions to adjust.

It's the same as the global values we set for all tests, so it's probably fine. For whatever reason, steps under the test stanza don't inherit the global request values, according to the linter anyway.

We can check after a few executions then, feel free to remove the hold!

openshift-ci · 2023-04-11T12:15:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/microshift/OWNERS~~ [copejon,pacevedom]
~~ci-operator/jobs/openshift/microshift/OWNERS~~ [copejon,pacevedom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

copejon · 2023-04-11T14:36:23Z

/unhold

copejon · 2023-04-13T14:13:30Z

/pj-rehearse ack

copejon · 2023-04-13T14:21:44Z

/pj-rehearse

eggfoobar · 2023-04-13T14:53:59Z

/test config

openshift-ci-robot · 2023-04-13T16:31:07Z

/retest-required

Remaining retests: 0 against base HEAD e565352 and 2 for PR HEAD 0755bad in total

openshift-ci · 2023-04-13T16:33:53Z

@copejon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2023-04-13T16:49:04Z

@copejon: Updated the following 2 configmaps:

ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
- key openshift-microshift-main.yaml using file ci-operator/config/openshift/microshift/openshift-microshift-main.yaml
job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
- key openshift-microshift-main-presubmits.yaml using file ci-operator/jobs/openshift/microshift/openshift-microshift-main-presubmits.yaml

Details

In response to this:

Golangci-lint cannot access the default directory to create the .cache subdir because the home dir does not exist. Specify the cache dir under /tmp to workaround this.

Unblocks openshift/microshift#1605

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot requested review from dhellmann and pacevedom April 10, 2023 16:26

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2023

copejon force-pushed the ushift-linter-cache branch from 0710929 to 6b323c1 Compare April 10, 2023 21:14

specify the golangling-ci cache location to fix access perms

8bff86e

copejon force-pushed the ushift-linter-cache branch from 6b323c1 to 8bff86e Compare April 10, 2023 21:18

copejon added 3 commits April 10, 2023 16:22

make update

8c8ca8b

remove dupe verify

541a326

make update

0755bad

pacevedom approved these changes Apr 11, 2023

View reviewed changes

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2023

openshift-ci Bot assigned pacevedom Apr 11, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2023

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2023

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 13, 2023

openshift-merge-robot merged commit 389a1a1 into openshift:master Apr 13, 2023

copejon deleted the ushift-linter-cache branch July 12, 2023 21:20

Conversation

copejon commented Apr 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 10, 2023

Uh oh!

copejon commented Apr 10, 2023

Uh oh!

copejon commented Apr 10, 2023

Uh oh!

openshift-ci Bot commented Apr 10, 2023

Uh oh!

copejon commented Apr 10, 2023

Uh oh!

copejon commented Apr 10, 2023

Uh oh!

copejon commented Apr 10, 2023

Uh oh!

copejon commented Apr 10, 2023

Uh oh!

copejon commented Apr 10, 2023

Uh oh!

pacevedom left a comment

Choose a reason for hiding this comment

Uh oh!

pacevedom Apr 11, 2023

Choose a reason for hiding this comment

Uh oh!

copejon Apr 11, 2023

Choose a reason for hiding this comment

Uh oh!

pacevedom Apr 11, 2023

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Apr 11, 2023

Uh oh!

copejon commented Apr 11, 2023

Uh oh!

copejon commented Apr 13, 2023

Uh oh!

copejon commented Apr 13, 2023

Uh oh!

eggfoobar commented Apr 13, 2023

Uh oh!

openshift-ci-robot commented Apr 13, 2023

Uh oh!

openshift-ci Bot commented Apr 13, 2023

Uh oh!

openshift-ci Bot commented Apr 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

copejon commented Apr 10, 2023 •

edited

Loading