Skip to content

MicroShift - set golangci-lint explicitly #38194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 4 commits into from
Apr 13, 2023
Merged

MicroShift - set golangci-lint explicitly #38194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8bff86e
specify the golangling-ci cache location to fix access perms
copejon Apr 10, 2023
8c8ca8b
make update
copejon Apr 10, 2023
541a326
remove dupe verify
copejon Apr 10, 2023
0755bad
make update
copejon Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions ci-operator/config/openshift/microshift/openshift-microshift-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,18 @@ tag_specification:
tests:
- as: verify
cluster: build02
commands: make verify
container:
from: src
steps:
test:
- as: verify
commands: make verify
env:
- default: /tmp/
name: GOLANGCI_LINT_CACHE
from: src
resources:
requests:
cpu: 100m
memory: 200Mi
Comment on lines +123 to +124
Copy link
Copy Markdown
Contributor

@pacevedom pacevedom Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only nit, is this enough for good scheduling? We can always check after a few executions to adjust.

Copy link
Copy Markdown
Contributor Author

@copejon copejon Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same as the global values we set for all tests, so it's probably fine. For whatever reason, steps under the test stanza don't inherit the global request values, according to the linter anyway.

Copy link
Copy Markdown
Contributor

@pacevedom pacevedom Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can check after a few executions then, feel free to remove the hold!

- as: test-unit
cluster: build02
commands: make test-unit
Expand Down
7 changes: 7 additions & 0 deletions ci-operator/jobs/openshift/microshift/openshift-microshift-main-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,6 +979,7 @@ presubmits:
- --gcs-upload-secret=/secrets/gcs/service-account.json
- --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
- --report-credentials-file=/etc/report/credentials
- --secret-dir=/secrets/ci-pull-credentials
- --target=verify
command:
- ci-operator
Expand All @@ -989,6 +990,9 @@ presubmits:
requests:
cpu: 10m
volumeMounts:
- mountPath: /secrets/ci-pull-credentials
name: ci-pull-credentials
readOnly: true
- mountPath: /secrets/gcs
name: gcs-credentials
readOnly: true
Expand All @@ -1000,6 +1004,9 @@ presubmits:
readOnly: true
serviceAccountName: ci-operator
volumes:
- name: ci-pull-credentials
secret:
secretName: ci-pull-credentials
- name: pull-secret
secret:
secretName: registry-pull-credentials
Expand Down