Skip to content

USHIFT-1423: Only test upgrades on metal#41143

Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
pacevedom:USHIFT-1423
Jul 13, 2023
Merged

USHIFT-1423: Only test upgrades on metal#41143
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
pacevedom:USHIFT-1423

Conversation

@pacevedom
Copy link
Copy Markdown
Contributor

@pacevedom pacevedom commented Jul 11, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 11, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 11, 2023 •
edited by openshift-ci Bot
Loading

@pacevedom: This pull request references USHIFT-1423 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 11, 2023

@pacevedom, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase repo client
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@openshift-ci openshift-ci Bot requested review from copejon and ggiguash July 11, 2023 10:51
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@pacevedom
Copy link
Copy Markdown
Contributor Author

pacevedom commented Jul 11, 2023

/pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests

dhellmann
dhellmann reviewed Jul 11, 2023
View reviewed changes
Comment thread ...registry/openshift/microshift/infra/iso-boot/openshift-microshift-infra-iso-boot-commands.sh Outdated
Copy link
Copy Markdown
Contributor

@dhellmann dhellmann Jul 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These variables are still being passed to the command at the end of this file when it runs the remote part of the boot process. We need to keep them until we can update that script to not need them.

Copy link
Copy Markdown
Contributor Author

@pacevedom pacevedom Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one slipped from a different PR, fixed it.

@dhellmann dhellmann mentioned this pull request Jul 11, 2023
Closed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 12, 2023

[REHEARSALNOTIFIER]
@pacevedom: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-microshift-main-microshift-metal-tests openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-main-microshift-metal-tests-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.15-microshift-metal-tests openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.15-microshift-metal-tests-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.14-microshift-metal-tests openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.14-microshift-metal-tests-arm openshift/microshift presubmit Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@pacevedom
Copy link
Copy Markdown
Contributor Author

pacevedom commented Jul 12, 2023

/pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests

@dhellmann
Copy link
Copy Markdown
Contributor

dhellmann commented Jul 12, 2023

The issue with ostree refs should be fixed.

/pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests

dhellmann
dhellmann reviewed Jul 12, 2023
View reviewed changes
Comment thread ...gistry/openshift/microshift/infra/iso-build/openshift-microshift-infra-iso-build-commands.sh

./test/bin/ci_phase_iso_build.sh

./scripts/image-builder/build.sh -pull_secret_file "\${PULL_SECRET}" -microshift_rpms ~/rpms -authorized_keys_file ~/.ssh/id_rsa.pub -open_firewall_ports 6443:tcp
Copy link
Copy Markdown
Contributor

@dhellmann dhellmann Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing an error on openshift/microshift#1989 that I think will be resolved by removing this step. See https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_microshift/1989/pull-ci-openshift-microshift-main-microshift-metal-tests/1679202926033113088#1:build-log.txt%3A4889 for example

Copy link
Copy Markdown
Contributor Author

@pacevedom pacevedom Jul 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This started happening in all builds. The issue is that there is a directory missing, but we didnt change the logic. Not sure if its worth fixing as merging this PR will make it disappear.

@dhellmann dhellmann mentioned this pull request Jul 12, 2023
Merged
@pacevedom
Copy link
Copy Markdown
Contributor Author

pacevedom commented Jul 12, 2023

/pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests

2 similar comments
@pacevedom
Copy link
Copy Markdown
Contributor Author

pacevedom commented Jul 13, 2023

/pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests

@pacevedom
Copy link
Copy Markdown
Contributor Author

pacevedom commented Jul 13, 2023

/pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests

@pmtk
Copy link
Copy Markdown
Member

pmtk commented Jul 13, 2023

/lgtm
/hold

unhold at your convenience

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2023
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacevedom
Copy link
Copy Markdown
Contributor Author

pacevedom commented Jul 13, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 13, 2023
@pacevedom
Copy link
Copy Markdown
Contributor Author

pacevedom commented Jul 13, 2023

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 13, 2023

@pacevedom: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/microshift/main/microshift-metal-tests a71a93c link unknown /pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 009324d into openshift:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@copejon copejon Awaiting requested review from copejon

@ggiguash ggiguash Awaiting requested review from ggiguash

1 more reviewer

@dhellmann dhellmann dhellmann left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pmtk pmtk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pacevedom @openshift-ci-robot @dhellmann @pmtk @openshift-merge-robot