Skip to content

Fix golang 1.13 RPM and add its image to the pipeline.#5314

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
markusthoemmes:golang1.13-fix
Oct 8, 2019
Merged

Fix golang 1.13 RPM and add its image to the pipeline.#5314
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
markusthoemmes:golang1.13-fix

Conversation

@markusthoemmes
Copy link
Copy Markdown
Contributor

  • The RPM seems to have been built for Mac. The docker build complained about it not being for the right architecture. Regenerated it in a docker container with an explicit --target makes the docker build successful on my machine.
  • Added the image to pipeline.yaml so it actually gets published and is therefore available.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 7, 2019
@markusthoemmes
Copy link
Copy Markdown
Contributor Author

/assign @stevekuznetsov

Copy link
Copy Markdown
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2019
@openshift-merge-robot openshift-merge-robot merged commit aee569d into openshift:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants