Skip to content

Add Golang 1.14.2 to CI and pipeline#8780

Closed
nak3 wants to merge 4 commits intoopenshift:masterfrom
nak3:golang-1.14
Closed

Add Golang 1.14.2 to CI and pipeline#8780
nak3 wants to merge 4 commits intoopenshift:masterfrom
nak3:golang-1.14

Conversation

@nak3
Copy link
Copy Markdown
Contributor

@nak3 nak3 commented May 4, 2020

1.14.2 is the current stable version of Golang.

The Knative project needs Go 1.14 to build the image, hence we need
this to be able to keep up with upstream and run it through CI.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nak3
To complete the pull request process, please assign petr-muller
You can assign the PR to them by writing /assign @petr-muller in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented May 4, 2020

I updated the files by referring to #5236 and #5314.
I hope that I didn't miss anything.

@nak3 nak3 changed the title Add Golang 1.13.1 to CI and pipeline Add Golang 1.14.2 to CI and pipeline May 4, 2020
@grdryn
Copy link
Copy Markdown
Member

grdryn commented May 8, 2020

@nak3 FYI it looks like @stevekuznetsov already had a PR for this in #8542

The two PRs look identical apart from this one having an RPM committed at projects/origin-release/golang-1.14/golang-v1.14.0-1.noarch.rpm

@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented May 8, 2020

Yes, thank you @grdryn I'm closing this.

@nak3 nak3 closed this May 8, 2020
@nak3 nak3 deleted the golang-1.14 branch May 8, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants