fix: OADP velero 1.4 branch

[mateusoliveira43]

Fix for unit tests in branch oadp-1.4 of Velero fork.

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@mateusoliveira43: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-velero-oadp-1.4-unit-test	openshift/velero	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[mateusoliveira43]

/pj-rehearse

[openshift-ci-robot]

@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mateusoliveira43]

/pj-rehearse ack

[openshift-ci-robot]

@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[kaovilai]

/lgtm
/pj-rehearse ack

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/velero/OWNERS [kaovilai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kaovilai]

This PR addresses issue with ci-tools openshift/ci-tools#4165

[openshift-ci]

@mateusoliveira43: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/velero/oadp-1.4/unit-test	a08422a	link	unknown	/pj-rehearse pull-ci-openshift-velero-oadp-1.4-unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mpryc]

Which image is that from?

I wonder if it's not easier to use one of the go env to ensure it's there ,because we can't be sure konveyor will always stay there:

https://github.com/konveyor/builder/blob/main/Dockerfile.ubi9#L13-L32

[kaovilai]

From here https://github.com/openshift/ci-tools/blame/master/pkg/steps/source.go#L102

This is added to our image when our repo is configured to use imagestreamtag which openshift prow replaces FROM in our dockerfile. Not something specified in konveyor builder.

[mateusoliveira43]

image_stream_tag line 2 (which would be fine)

but as Tiger noted openshift/ci-tools#4165 this is needed

[mpryc]

thanks !