Skip to content

OADP-4308: Don't consider unschedulable pods unrecoverable#317

Merged
weshayutin merged 1 commit into
openshift:oadp-1.4from
sseago:ceph-unschedulable
Jun 14, 2024
Merged

OADP-4308: Don't consider unschedulable pods unrecoverable#317
weshayutin merged 1 commit into
openshift:oadp-1.4from
sseago:ceph-unschedulable

Conversation

@sseago
Copy link
Copy Markdown

@sseago sseago commented Jun 14, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 14, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 14, 2024

@sseago: This pull request references OADP-4308 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mateusoliveira43
Copy link
Copy Markdown

For unit tests to pass, need these 2 PRs:

Copy link
Copy Markdown

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
Copy link
Copy Markdown
Member

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mpryc
Copy link
Copy Markdown

mpryc commented Jun 14, 2024

CI issue - goimports, but it's known

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kaovilai, mpryc, shubham-pampattiwar, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sseago
Copy link
Copy Markdown
Author

sseago commented Jun 14, 2024

Fix forthcoming for unit tests. Prow will still fail them, though.

Signed-off-by: Scott Seago <sseago@redhat.com>
@sseago sseago force-pushed the ceph-unschedulable branch from b107169 to 9decb91 Compare June 14, 2024 15:19
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 14, 2024

@sseago: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-test 9decb91 link false /test unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sseago
Copy link
Copy Markdown
Author

sseago commented Jun 14, 2024

/override ci/prow/unit-test

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 14, 2024

@sseago: sseago unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

Details

In response to this:

/override ci/prow/unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shubham-pampattiwar
Copy link
Copy Markdown
Member

/override ci/prow/unit-test

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 14, 2024

@shubham-pampattiwar: shubham-pampattiwar unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

Details

In response to this:

/override ci/prow/unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@weshayutin
Copy link
Copy Markdown

ok  	github.com/vmware-tanzu/velero/internal/volume	0.051s	coverage: 48.9% of statements
ok  	github.com/vmware-tanzu/velero/internal/volumehelper	0.057s	coverage: 37.4% of statements
Success!
make[1]: Leaving directory '/home/whayutin/OPENSHIFT/git/OADP/velero'

/LGTM

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
@weshayutin weshayutin merged commit 6fbcfbf into openshift:oadp-1.4 Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants