Skip to content

Ensure Origin is promoting from fcos + CI image sources#5647

Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
smarterclayton:fcos_branches
Oct 29, 2019
Merged

Ensure Origin is promoting from fcos + CI image sources#5647
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
smarterclayton:fcos_branches

Conversation

@smarterclayton
Copy link
Copy Markdown
Contributor

@smarterclayton smarterclayton commented Oct 29, 2019 •
edited
Loading

See commits for descriptions.

Includes and supersedes #5603

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 29, 2019
Vadim Rutkovsky and others added 2 commits October 29, 2019 12:21
@smarterclayton
Add jobs to build FCOS forks of MCD and installer
7b91721 
These jobs will inherit from Origin and publish back to Origin.
The release controller will take all 4.3 CI images except these
and publish them into origin 4.3.
@smarterclayton
Release controller should skip certain 4.3 images in promote to origin
b96fc0a 
4.3 CI is the source for all OKD images except the known list. Publish
those directly.

Remove release controller definitions for 4.2 and 4.1 OKD which are not
valid.

Update the hack/build script to be more friendly.
vrutkovs
vrutkovs approved these changes Oct 29, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. e2e tests don't work (yet), gofmt issue is fixed in spec3 PR for installer

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9e5cabc into openshift:master Oct 29, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 29, 2019

@smarterclayton: Updated the plugins configmap in namespace ci using the following files:

  • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml
Details

In response to this:

See commits for descriptions.

Includes and supersedes #5603

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 29, 2019

@smarterclayton: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/fcos/gofmt 17dad78 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/fcos/e2e-aws 17dad78 link /test pj-rehearse
ci/rehearse/openshift/installer/fcos/e2e-aws 17dad78 link /test pj-rehearse
ci/prow/pj-rehearse 17dad78 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

1 more reviewer

@vrutkovs vrutkovs vrutkovs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vrutkovs vrutkovs

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smarterclayton @openshift-ci-robot @vrutkovs @LorbusChris @openshift-merge-robot