Skip to content

OKD 4.4: run e2e test on machine-os-content promotion#6558

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
vrutkovs:okd-4-4-run-aws-test
Mar 4, 2020
Merged

OKD 4.4: run e2e test on machine-os-content promotion#6558
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
vrutkovs:okd-4-4-run-aws-test

Conversation

@vrutkovs
Copy link
Copy Markdown
Contributor

@vrutkovs vrutkovs commented Jan 4, 2020 •
edited
Loading

Ensure new FCOS changes don't break OKD. This ensures pending machine-os-content update is being tested on AWS.

This also includes a fix for vmtoolsd.service symlink (fixes okd-project/okd#46)

Test results: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_release/6558/rehearse-6558-promote-release-openshift-okd-machine-os-content-e2e-aws-4.4/61

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2020
@vrutkovs vrutkovs force-pushed the okd-4-4-run-aws-test branch 2 times, most recently from 4ffc15c to 8df4905 Compare January 6, 2020 12:02
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2020
@vrutkovs vrutkovs force-pushed the okd-4-4-run-aws-test branch from 12a2f88 to 0a53b0d Compare January 7, 2020 16:23
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2020
@vrutkovs vrutkovs force-pushed the okd-4-4-run-aws-test branch 2 times, most recently from 6519a6b to dcd4a5d Compare January 7, 2020 22:06
@vrutkovs vrutkovs mentioned this pull request Jan 7, 2020
Closed
@vrutkovs vrutkovs force-pushed the okd-4-4-run-aws-test branch 12 times, most recently from 33c01b3 to 5d7e746 Compare January 8, 2020 09:55
LorbusChris
LorbusChris reviewed Jan 10, 2020
View reviewed changes
Comment thread ci-operator/jobs/openshift/release/openshift-release-release-4.4-periodics.yaml Outdated
Copy link
Copy Markdown
Contributor

@LorbusChris LorbusChris Jan 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Copy Markdown
Contributor

@LorbusChris LorbusChris Jan 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh is it because it would otherwise run all the tests, whereas we just want to run the e2e test?

Copy link
Copy Markdown
Contributor

@smarterclayton smarterclayton Mar 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to run all tests, that is what --target TEST_NAME does.

Copy link
Copy Markdown
Contributor Author

@vrutkovs vrutkovs Mar 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A custom CONFIG_SPEC section is required to import machine-os-content from fcos (see base_images there) and promotion section (added --promote option to ci-operator)

@LorbusChris
Copy link
Copy Markdown
Contributor

LorbusChris commented Jan 10, 2020

Could you split out the vsphere changes into another PR for clarity? Let's make it work on AWS first

@vrutkovs vrutkovs force-pushed the okd-4-4-run-aws-test branch from 5d7e746 to efa3914 Compare January 14, 2020 13:42
This was referenced Jan 14, 2020
Merged
Merged
@vrutkovs vrutkovs force-pushed the okd-4-4-run-aws-test branch from efa3914 to 16cab70 Compare January 16, 2020 13:35
@vrutkovs vrutkovs force-pushed the okd-4-4-run-aws-test branch 5 times, most recently from 2140f13 to 45a94ba Compare February 28, 2020 13:08
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 28, 2020
@vrutkovs vrutkovs force-pushed the okd-4-4-run-aws-test branch from 45a94ba to b0399b3 Compare February 28, 2020 15:00
@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Feb 28, 2020

/retest

@vrutkovs vrutkovs force-pushed the okd-4-4-run-aws-test branch 2 times, most recently from 4b3ea6c to c31a565 Compare February 29, 2020 00:07
@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Feb 29, 2020

/retest

@vrutkovs vrutkovs force-pushed the okd-4-4-run-aws-test branch 6 times, most recently from e53608e to a67d5f7 Compare February 29, 2020 22:56
@vrutkovs vrutkovs changed the title WIP OKD 4.4: run e2e test on machine-os-content promotion OKD 4.4: run e2e test on machine-os-content promotion Mar 1, 2020
@vrutkovs vrutkovs force-pushed the okd-4-4-run-aws-test branch from 0f3a165 to 32e14e4 Compare March 1, 2020 12:19
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2020
@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Mar 1, 2020

flakes

/retest

@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Mar 1, 2020

Marketplace flakes

/retest

@vrutkovs vrutkovs force-pushed the okd-4-4-run-aws-test branch from 32e14e4 to 2748083 Compare March 2, 2020 19:08
@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Mar 4, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 4, 2020

@vrutkovs: Updated the job-config-4.4 configmap in namespace ci at cluster default using the following files:

  • key openshift-release-release-4.4-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.4-periodics.yaml
Details

In response to this:

Ensure new FCOS changes don't break OKD. This ensures pending machine-os-content update is being tested on AWS.

This also includes a fix for vmtoolsd.service symlink (fixes okd-project/okd#46)

Test results: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_release/6558/rehearse-6558-promote-release-openshift-okd-machine-os-content-e2e-aws-4.4/61

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

2 more reviewers

@smarterclayton smarterclayton smarterclayton left review comments

@LorbusChris LorbusChris LorbusChris left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

open-vm-tools doesn't start

5 participants

@vrutkovs @LorbusChris @smarterclayton @openshift-ci-robot @openshift-merge-robot