Skip to content

OKD: expose fedora repos on okd-4.x.origin.svc service#6588

Closed
vrutkovs wants to merge 3 commits intoopenshift:masterfrom
vrutkovs:okd-fedora-repos
Closed

OKD: expose fedora repos on okd-4.x.origin.svc service#6588
vrutkovs wants to merge 3 commits intoopenshift:masterfrom
vrutkovs:okd-fedora-repos

Conversation

@vrutkovs
Copy link
Copy Markdown
Contributor

@vrutkovs vrutkovs commented Jan 7, 2020

This creates new services and deployments in origin namespace with content-mirror serving F31 repos for OKD 4.3-4.5 machine-os-content.

Current we're using repos from coreos-assembler container, which might eventually not match FCOS testing-devel stream

See TODO in https://github.com/openshift/release/pull/6415/files#r358290501

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 7, 2020
@vrutkovs vrutkovs changed the title OKD: expose fedora repos on old-4.x.origin.svc service OKD: expose fedora repos on okd-4.x.origin.svc service Jan 7, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: replace with modular and updates-modular when https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2019-24636b4ff9 lands

@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Jan 7, 2020

/cc @smarterclayton

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 7, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@vrutkovs: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/build-farm/build01-dry 5e9a1b8 link /test build01-dry

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Jan 7, 2020

Dry run fails with:

User \"system:serviceaccount:ci:config-updater\" cannot get resource \"services\" in API group \"\" in the namespace \"origin\"` although Role adds this permission - should I split it in a different PR for clarity? 

@cgwalters
Copy link
Copy Markdown
Member

Current we're using repos from coreos-assembler container, which might eventually not match FCOS testing-devel stream

True; hmm...it'd be cleanest to get the repo files from the machine-os-content I think? But this is also fine!

@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Jan 7, 2020

True; hmm...it'd be cleanest to get the repo files from the machine-os-content I think? But this is also fine!

Duh, I'm overcomplicating this :/ Testing this in #6558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants