Skip to content

Add fips related presubmit for router#77050

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
lihongan:add-presubmit-fips
Apr 2, 2026
Merged

Add fips related presubmit for router#77050
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
lihongan:add-presubmit-fips

Conversation

@lihongan
Copy link
Copy Markdown

@lihongan lihongan commented Mar 30, 2026 •
edited
Loading

adding two FIPS related presubmits for router

  • fips-image-scan-haproxy-router: scans haproxy-router image for FIPS-compliant binaries (light weight, no cluster needed)
  • e2e-aws-fips: runs conformance tests on a FIPS-enabled AWS cluster with fips-check validation

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 30, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@lihongan
Copy link
Copy Markdown
Author

lihongan commented Mar 30, 2026

/test all

@lihongan
Copy link
Copy Markdown
Author

lihongan commented Mar 30, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 30, 2026

@lihongan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@lihongan lihongan marked this pull request as ready for review March 30, 2026 08:38
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2026
@openshift-ci openshift-ci Bot requested review from Miciah and gcs278 March 30, 2026 08:39
@lihongan
Copy link
Copy Markdown
Author

lihongan commented Mar 30, 2026

/pj-rehearse list

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 30, 2026

@lihongan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@lihongan
Copy link
Copy Markdown
Author

lihongan commented Mar 30, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 30, 2026

@lihongan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 30, 2026

@Miciah: the repo openshift/release does not contribute to the OpenShift official images, or the base branch is not currently having images promoted

1 similar comment
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 30, 2026

@Miciah: the repo openshift/release does not contribute to the OpenShift official images, or the base branch is not currently having images promoted

@Miciah
Copy link
Copy Markdown
Contributor

Miciah commented Mar 30, 2026

Sorry, I meant to put the comment on the router PR: openshift/router#755 (comment)

@lihongan lihongan force-pushed the add-presubmit-fips branch from 5711438 to a9c5250 Compare March 31, 2026 03:18
@lihongan
Copy link
Copy Markdown
Author

lihongan commented Mar 31, 2026

/pj-rehearse list

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 31, 2026

@lihongan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@lihongan
Copy link
Copy Markdown
Author

lihongan commented Mar 31, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 31, 2026

@lihongan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@lihongan
Copy link
Copy Markdown
Author

lihongan commented Mar 31, 2026

/pj-rehearse pull-ci-openshift-router-master-e2e-aws-fips

The HAProxy router should pass the h2spec conformance tests test failed, flaky ?

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 31, 2026

@lihongan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@lihongan
Copy link
Copy Markdown
Author

lihongan commented Mar 31, 2026

/pj-rehearse pull-ci-openshift-router-master-e2e-aws-fips

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 31, 2026

@lihongan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@lihongan
Copy link
Copy Markdown
Author

lihongan commented Mar 31, 2026

/pj-rehearse pull-ci-openshift-router-master-e2e-aws-fips

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 31, 2026

@lihongan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@lihongan
Copy link
Copy Markdown
Author

lihongan commented Apr 1, 2026

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 1, 2026

@lihongan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 1, 2026
@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 1, 2026
@melvinjoseph86
Copy link
Copy Markdown
Contributor

melvinjoseph86 commented Apr 1, 2026

/retest-required

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented Apr 1, 2026

/retest-required

Remaining retests: 0 against base HEAD e428f4a and 2 for PR HEAD a9c5250 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented Apr 1, 2026

/retest-required

Remaining retests: 0 against base HEAD 329e435 and 1 for PR HEAD a9c5250 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented Apr 1, 2026

/retest-required

Remaining retests: 0 against base HEAD a86745b and 0 for PR HEAD a9c5250 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented Apr 1, 2026

/hold

Revision a9c5250 was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2026
@lihongan
Copy link
Copy Markdown
Author

lihongan commented Apr 2, 2026

looks need to rerun make jobs to generate config. let me try

Add fips related presubmit for router
a88228a 
fips-image-scan-haproxy-router: scans haproxy-router image for FIPS-compliant binaries (light weight, no cluster needed)
e2e-aws-fips: runs conformance tests on a FIPS-enabled AWS cluster with fips-check validation
@lihongan lihongan force-pushed the add-presubmit-fips branch from a9c5250 to a88228a Compare April 2, 2026 04:14
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 2, 2026

[REHEARSALNOTIFIER]
@lihongan: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-router-master-e2e-aws-fips openshift/router presubmit Presubmit changed
pull-ci-openshift-router-master-fips-image-scan-haproxy-router openshift/router presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 2, 2026
@lihongan
Copy link
Copy Markdown
Author

lihongan commented Apr 2, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 2, 2026

@lihongan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@lihongan
Copy link
Copy Markdown
Author

lihongan commented Apr 2, 2026

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 2, 2026

@lihongan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 2, 2026
@lihongan
Copy link
Copy Markdown
Author

lihongan commented Apr 2, 2026

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2026
@alebedev87
Copy link
Copy Markdown
Contributor

alebedev87 commented Apr 2, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, lihongan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 2, 2026

@lihongan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit b2469ad into openshift:main Apr 2, 2026
17 checks passed
vimauro pushed a commit to vimauro/release that referenced this pull request Apr 2, 2026
@vimauro
Add fips related presubmit for router (openshift#77050)
3de5beb 
fips-image-scan-haproxy-router: scans haproxy-router image for FIPS-compliant binaries (light weight, no cluster needed)
e2e-aws-fips: runs conformance tests on a FIPS-enabled AWS cluster with fips-check validation
acornett21 pushed a commit to acornett21/openshift-release that referenced this pull request Apr 3, 2026
@acornett21
Add fips related presubmit for router (openshift#77050)
ea991ac 
fips-image-scan-haproxy-router: scans haproxy-router image for FIPS-compliant binaries (light weight, no cluster needed)
e2e-aws-fips: runs conformance tests on a FIPS-enabled AWS cluster with fips-check validation
@lihongan lihongan deleted the add-presubmit-fips branch April 7, 2026 08:21
HarshwardhanPatil07 pushed a commit to HarshwardhanPatil07/release that referenced this pull request Apr 23, 2026
@HarshwardhanPatil07
Add fips related presubmit for router (openshift#77050)
bc4856f 
fips-image-scan-haproxy-router: scans haproxy-router image for FIPS-compliant binaries (light weight, no cluster needed)
e2e-aws-fips: runs conformance tests on a FIPS-enabled AWS cluster with fips-check validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gcs278 gcs278 Awaiting requested review from gcs278

@Miciah Miciah Awaiting requested review from Miciah

1 more reviewer

@alebedev87 alebedev87 alebedev87 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@alebedev87 alebedev87

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lihongan @openshift-ci-robot @Miciah @melvinjoseph86 @alebedev87