NE-2333: Add support for TLS curves in HAProxy configuration#755
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe HAProxy configuration template now conditionally emits an Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/retitle NE-2332: Add support for TLS curves in HAProxy configuration |
|
@richardsonnick: This pull request references NE-2332 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve Thanks for your patience and responsiveness! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
57ddf89 to
bb81f04
Compare
Introduces the ROUTER_CURVES environment variable which maps directly to HAProxy's ssl-default-bind-curves directive, allowing operators to configure the TLS key exchange groups used by the router. When ROUTER_CURVES is not set, no directive is emitted and HAProxy uses its built-in defaults.
bb81f04 to
8997b3d
Compare
|
/lgtm |
|
@richardsonnick: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-upgrade-fips |
|
@Miciah: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/34159260-2c54-11f1-89b2-7977742c8eef-0 |
|
/verified by @lihongan |
|
@lihongan: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Change included in accepted release 4.22.0-0.nightly-2026-04-01-092906 |
|
Replaces #678 |
|
/retitle NE-2333: Add support for TLS curves in HAProxy configuration |
|
/jira refresh |
Introduces the ROUTER_CURVES environment variable which maps directly to HAProxy's ssl-default-bind-curves directive, allowing operators to configure the TLS key exchange groups used by the router. When ROUTER_CURVES is not set, no directive is emitted and HAProxy uses its built-in defaults.