NO-JIRA don't auto approve PRs in control-plane repos

[atiratree]

authors of PRs should find a control plane approver if possible before approving their own PRs

Summary by CodeRabbit

• Chores
  • Updated approval workflow configurations across multiple repositories to standardize self-approval requirements and bot command handling for pull request approvals.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a94e0617-8987-487c-9672-19c5f390d8f9

📥 Commits

Reviewing files that changed from the base of the PR and between 624a6f9 and 1151004.

📒 Files selected for processing (25)

• core-services/prow/02_config/openshift/apiserver-library-go/_pluginconfig.yaml
• core-services/prow/02_config/openshift/build-machinery-go/_pluginconfig.yaml
• core-services/prow/02_config/openshift/cli-manager-operator/_pluginconfig.yaml
• core-services/prow/02_config/openshift/cli-manager/_pluginconfig.yaml
• core-services/prow/02_config/openshift/cluster-authentication-operator/_pluginconfig.yaml
• core-services/prow/02_config/openshift/cluster-bootstrap/_pluginconfig.yaml
• core-services/prow/02_config/openshift/cluster-etcd-operator/_pluginconfig.yaml
• core-services/prow/02_config/openshift/cluster-image-registry-operator/_pluginconfig.yaml
• core-services/prow/02_config/openshift/cluster-kube-apiserver-operator/_pluginconfig.yaml
• core-services/prow/02_config/openshift/cluster-kube-descheduler-operator/_pluginconfig.yaml
• core-services/prow/02_config/openshift/cluster-kube-scheduler-operator/_pluginconfig.yaml
• core-services/prow/02_config/openshift/cluster-kube-storage-version-migrator-operator/_pluginconfig.yaml
• core-services/prow/02_config/openshift/cluster-openshift-apiserver-operator/_pluginconfig.yaml
• core-services/prow/02_config/openshift/cluster-openshift-controller-manager-operator/_pluginconfig.yaml
• core-services/prow/02_config/openshift/cluster-policy-controller/_pluginconfig.yaml
• core-services/prow/02_config/openshift/jobset-operator/_pluginconfig.yaml
• core-services/prow/02_config/openshift/lws-operator/_pluginconfig.yaml
• core-services/prow/02_config/openshift/multi-operator-manager/_pluginconfig.yaml
• core-services/prow/02_config/openshift/oauth-apiserver/_pluginconfig.yaml
• core-services/prow/02_config/openshift/openshift-apiserver/_pluginconfig.yaml
• core-services/prow/02_config/openshift/openshift-controller-manager/_pluginconfig.yaml
• core-services/prow/02_config/openshift/run-once-duration-override-operator/_pluginconfig.yaml
• core-services/prow/02_config/openshift/run-once-duration-override/_pluginconfig.yaml
• core-services/prow/02_config/openshift/secondary-scheduler-operator/_pluginconfig.yaml
• core-services/prow/02_config/openshift/service-ca-operator/_pluginconfig.yaml

---

Walkthrough

Updates Prow approval plugin configurations across 25 OpenShift repositories. Changes introduce new top-level approve configuration blocks specifying bot command help links and repository scopes, while simultaneously converting six existing configurations to require self-approval by setting require_self_approval to true.

Changes

Cohort / File(s)	Summary
New Approve Block Additions core-services/prow/02_config/openshift/{apiserver-library-go,build-machinery-go,cluster-authentication-operator,cluster-bootstrap,cluster-etcd-operator,cluster-image-registry-operator,cluster-kube-apiserver-operator,cluster-kube-descheduler-operator,cluster-kube-scheduler-operator,cluster-kube-storage-version-migrator-operator,cluster-openshift-apiserver-operator,cluster-openshift-controller-manager-operator,cluster-policy-controller,oauth-apiserver,openshift-apiserver,openshift-controller-manager,run-once-duration-override-operator,run-once-duration-override,service-ca-operator}/_pluginconfig.yaml	Introduces top-level approve configuration block with commandHelpLink, repos listing, and require_self_approval: true for each repository.
Self-Approval Requirement Updates core-services/prow/02_config/openshift/{cli-manager-operator,cli-manager,jobset-operator,lws-operator,multi-operator-manager,secondary-scheduler-operator}/_pluginconfig.yaml	Modifies existing approve configuration to change require_self_approval from false to true.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: requiring self-approval for control-plane repos instead of allowing automatic approval.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR contains only Prow plugin configuration YAML files with no Ginkgo tests or test code.
Test Structure And Quality	✅ Passed	This PR contains only YAML configuration file changes for Prow plugin configurations with no Ginkgo test code or Go test files being modified.
Microshift Test Compatibility	✅ Passed	This pull request does not add any new Ginkgo e2e tests. All changes are limited to YAML Prow plugin configuration files for OpenShift repositories.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This pull request does not add any Ginkgo e2e tests, only modifies Prow configuration YAML files for governance enforcement.
Topology-Aware Scheduling Compatibility	✅ Passed	Pull request modifies only Prow CI/CD plugin configuration files in core-services/prow/02_config/ with no Kubernetes deployment manifests, operator code, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	PR modifies only Prow plugin configuration YAML files with no Go code or process-level code that writes to stdout.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies only Prow CI/CD configuration files; no new Ginkgo e2e tests added, so check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@atiratree: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

[openshift-ci]

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[kevinrizza]

/lgtm

[rh-roman]

/lgtm

[everettraven]

/lgtm

[atiratree]

/honk

[openshift-ci]

@atiratree:

Details

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[atiratree]

refresh approve list
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atiratree, everettraven, kevinrizza, rh-roman
Once this PR has been reviewed and has the lgtm label, please assign bertinatto, deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• core-services/prow/02_config/openshift/apiserver-library-go/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/build-machinery-go/OWNERS
• core-services/prow/02_config/openshift/cli-manager/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/cli-manager-operator/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/cluster-authentication-operator/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/cluster-bootstrap/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/cluster-etcd-operator/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/cluster-image-registry-operator/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/cluster-kube-apiserver-operator/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/cluster-kube-descheduler-operator/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/cluster-kube-scheduler-operator/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/cluster-kube-storage-version-migrator-operator/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/cluster-openshift-apiserver-operator/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/cluster-openshift-controller-manager-operator/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/cluster-policy-controller/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/jobset-operator/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/lws-operator/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/multi-operator-manager/OWNERS
• core-services/prow/02_config/openshift/oauth-apiserver/OWNERS
• core-services/prow/02_config/openshift/openshift-apiserver/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/openshift-controller-manager/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/run-once-duration-override/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/run-once-duration-override-operator/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/secondary-scheduler-operator/OWNERS [atiratree,everettraven,rh-roman]
• core-services/prow/02_config/openshift/service-ca-operator/OWNERS [atiratree,everettraven,rh-roman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[atiratree]

Let's wait for these two PRs to merge first

• autoowners: do not ignore openshift/build-machinery-go and openshift/oauth-apiserver #78640
• NO-JIRA: Add control-plane-approvers to OWNERS multi-operator-manager#67