Skip to content

NO-JIRA: Add control-plane-approvers to OWNERS#67

Open
kevinrizza wants to merge 1 commit intoopenshift:masterfrom
kevinrizza:add-control-plane-approvers
Open

NO-JIRA: Add control-plane-approvers to OWNERS#67
kevinrizza wants to merge 1 commit intoopenshift:masterfrom
kevinrizza:add-control-plane-approvers

Conversation

@kevinrizza
Copy link
Copy Markdown
Member

Add control-plane-approvers to OWNERS

@openshift-ci openshift-ci Bot requested review from deads2k and p0lyn0mial April 17, 2026 16:58
@kevinrizza
Copy link
Copy Markdown
Member Author

/retitle NO-JIRA: Add control-plane-approvers to OWNERS

@openshift-ci openshift-ci Bot changed the title Add control-plane-approvers to OWNERS NO-JIRA: Add control-plane-approvers to OWNERS Apr 17, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@kevinrizza: This pull request explicitly references no jira issue.

Details

In response to this:

Add control-plane-approvers to OWNERS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sanchezl
Copy link
Copy Markdown

/lgtm
/verified bypass
/retest-required

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@sanchezl: The verified label has been added.

Details

In response to this:

/lgtm
/verified bypass
/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2026
@p0lyn0mial
Copy link
Copy Markdown
Contributor

the required CI jobs fail on:

{  go test  -race ./pkg/... ./cmd/... 
go: go.mod requires go >= 1.24.0 (running go 1.22.9; GOTOOLCHAIN=local)
make: *** [vendor/github.com/openshift/build-machinery-go/make/targets/golang/test-unit.mk:7: test-unit] Error 1
{"component":"entrypoint","error":"wrapped process failed: exit status 2","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2026-04-27T15:59:14Z"}
}

@p0lyn0mial
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD b64ebc8 and 2 for PR HEAD 32f9ae3 in total

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 29, 2026

@kevinrizza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 32f9ae3 link true /test verify
ci/prow/unit 32f9ae3 link true /test unit
ci/prow/test-operator-integration 32f9ae3 link true /test test-operator-integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@p0lyn0mial
Copy link
Copy Markdown
Contributor

@kevinrizza #69 should help PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants