Skip to content

mom: use build_root from repository#78568

Open
p0lyn0mial wants to merge 1 commit intoopenshift:mainfrom
p0lyn0mial:mom-fix-build-root
Open

mom: use build_root from repository#78568
p0lyn0mial wants to merge 1 commit intoopenshift:mainfrom
p0lyn0mial:mom-fix-build-root

Conversation

@p0lyn0mial
Copy link
Copy Markdown
Contributor

@p0lyn0mial p0lyn0mial commented Apr 29, 2026

use build_root: from_repository: true so the go ver is controlled by the repo's .ci-operator.yaml instead of being hardcoded.

matches what we have for kas-o

should unblock openshift/multi-operator-manager#69 and openshift/multi-operator-manager#67

Summary by CodeRabbit

  • Chores
    • Updated build configuration to use repository-derived build root settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

Walkthrough

Updated the build_root configuration in a CI operator manifest file by removing an OpenShift image stream tag reference and switching to a repository-derived build root via from_repository: true.

Changes

Cohort / File(s) Summary
Build Root Configuration
ci-operator/config/openshift/multi-operator-manager/openshift-multi-operator-manager-master.yaml
Changed build root image source from explicit OpenShift image stream tag (RHEL/Golang/OpenShift 4.19) to repository-derived configuration via from_repository: true.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Title check ✅ Passed The title 'mom: use build_root from repository' clearly and concisely summarizes the main change: switching the build_root configuration to use the repository's own settings instead of a hardcoded image reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI/CD configuration YAML file with no test files or Ginkgo test definitions introduced or modified.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test code quality is not applicable to this pull request. The PR modifies only a CI/CD configuration file with no test code changes.
Microshift Test Compatibility ✅ Passed PR modifies only CI configuration file, no new Ginkgo e2e tests added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies CI operator configuration YAML; no Ginkgo e2e tests added or modified.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI operator build configuration, not deployment manifests, operator code, or controllers with scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The OTE Binary Stdout Contract check is not applicable to this PR as it only modifies a YAML CI configuration file without any Go code changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies only the CI operator configuration file, not Ginkgo e2e test code, so the check for new test code is not applicable.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

/assign @kevinrizza

@openshift-ci openshift-ci Bot requested review from benluddy and bertinatto April 29, 2026 15:46
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2026
@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@p0lyn0mial: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@p0lyn0mial: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-multi-operator-manager-master-test-operator-integration openshift/multi-operator-manager presubmit Ci-operator config changed
pull-ci-openshift-multi-operator-manager-master-unit openshift/multi-operator-manager presubmit Ci-operator config changed
pull-ci-openshift-multi-operator-manager-master-verify openshift/multi-operator-manager presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

@p0lyn0mial: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generated-config 10f3b76 link true /test generated-config
ci/rehearse/openshift/multi-operator-manager/master/unit 10f3b76 link unknown /pj-rehearse pull-ci-openshift-multi-operator-manager-master-unit
ci/rehearse/openshift/multi-operator-manager/master/verify 10f3b76 link unknown /pj-rehearse pull-ci-openshift-multi-operator-manager-master-verify
ci/rehearse/openshift/multi-operator-manager/master/test-operator-integration 10f3b76 link unknown /pj-rehearse pull-ci-openshift-multi-operator-manager-master-test-operator-integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kevinrizza
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kevinrizza
Copy link
Copy Markdown
Member

  • failed to generate steps from config: failed to get steps from configuration: failed to read buildRootImageStream from repository: failed to read .ci-operator.yaml file: open /home/prow/go/src/github.com/openshift/multi-operator-manager/.ci-operator.yaml: no such file or directory

This is odd. The file is definitely there in the repo https://github.com/openshift/multi-operator-manager/blob/master/.ci-operator.yaml

Is there some other configuration thing going wrong here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants