-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add periodic 31-day-cert-recovery #9521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cac687a to
6daebad
Compare
04d2606 to
14c27de
Compare
5ba98bd to
cd21e28
Compare
tnozicka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sally!
Please set it up as pre-submit on KCMO too but always_run: false for now. I'd like the test first before merging the fix.
I'd like to merge the version with integrated so we aren't flaky based on external registry cert lifetime when we move the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the inline syntax with \n is hard to review, why not this?
value: |
your code
next line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was multi-line, but then when I make jobs it becomes 1 line 🤷 I know, super hard to read, lemme ask platform team: @petr-muller how do i keep this multi-line? thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if there is some form of input that the YAML marshaler would respect and output reasonable YAML on write. Not that I know of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @petr-muller I'm closing this, moving to step-registry :) where it's more sane #12878
cd21e28 to
016a3bb
Compare
|
@sallyom: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
83e9b1c to
f2abe19
Compare
|
/retest |
2658c52 to
7116f68
Compare
7116f68 to
d20091a
Compare
|
@sallyom: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
moving this to step-registry: #12878 closing this in favor of 12878 |
This test starts a nested libvirt (3 control plane nodes, 2 compute nodes) cluster in a gcp instance and:
should fail until: openshift/cluster-kube-scheduler-operator#288
/assign @tnozicka
/cc @soltysh