Skip to content

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented Oct 15, 2020

This periodic test starts a nested libvirt (3 control plane nodes, 2 compute nodes) cluster in a gcp instance and:

  • stop / start crio & kubelet in each node
  • sets date of each node ahead
  • set date of gcp host ahead
  • approves all certificate-signing-requests
  • waits for:
    • all nodes Ready
    • no pending pods
    • all ClusterOperators are Available=True, Pending=False, Degraded=False

should fail until: openshift/cluster-kube-scheduler-operator#288

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2020
@alvaroaleman
Copy link
Contributor

/uncc

@openshift-ci-robot openshift-ci-robot removed the request for review from alvaroaleman October 15, 2020 21:16
@sallyom sallyom force-pushed the cert-recovery-1-yr branch 16 times, most recently from bc5c248 to 7c3a19b Compare October 17, 2020 02:36
@sallyom sallyom changed the title WIP: Add periodic for testing certificate rotation Add periodic job for testing certificate rotation after 1 year (bumping date in libvirt nested cluster) Oct 17, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2020
@sallyom
Copy link
Contributor Author

sallyom commented Oct 17, 2020

/hold

until this merges: #12825

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 17, 2020
@sallyom sallyom force-pushed the cert-recovery-1-yr branch from 7c3a19b to c93703d Compare October 19, 2020 17:51
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2020
@sallyom sallyom force-pushed the cert-recovery-1-yr branch from c93703d to 8a9fcc8 Compare October 19, 2020 19:56
@sallyom sallyom force-pushed the cert-recovery-1-yr branch from 1f56fcb to b87e963 Compare January 22, 2021 22:37
@sallyom
Copy link
Contributor Author

sallyom commented Jan 22, 2021

@tnozicka rebased/cleared conflicts - next week let's discuss & merge if possible :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was a flake, for sure, I haven't seen another run only get 1 worker.. i'll keep an eye out for it, once this merges, I'll take ownership to watch flakes

@sallyom sallyom force-pushed the cert-recovery-1-yr branch 3 times, most recently from cd1e116 to e397f55 Compare January 26, 2021 22:23
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2021
@sallyom sallyom force-pushed the cert-recovery-1-yr branch from e397f55 to e51b17d Compare January 26, 2021 23:05
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2021
@sallyom sallyom force-pushed the cert-recovery-1-yr branch 2 times, most recently from 9e0fa5c to 6e26b3a Compare January 27, 2021 01:51
@sallyom
Copy link
Contributor Author

sallyom commented Jan 27, 2021

/retest

@sallyom sallyom force-pushed the cert-recovery-1-yr branch from 6e26b3a to 1f2dabe Compare January 27, 2021 15:09
@tnozicka
Copy link
Contributor

tnozicka commented Jan 27, 2021

/approve
This is ready and the nits can be addressed as followups. Good job @sallyom!
Expectation is to see:

  • 4.7 passing
  • 4.6 passing
  • 4.5 failing but optional until the KS backport lands

@sallyom sallyom force-pushed the cert-recovery-1-yr branch 2 times, most recently from aa9517b to c256990 Compare January 27, 2021 21:02
@sallyom
Copy link
Contributor Author

sallyom commented Jan 27, 2021

yay, rehearsals are green again. will retest to get a few good runs

/retest

@sallyom sallyom force-pushed the cert-recovery-1-yr branch from c256990 to ee60550 Compare January 27, 2021 23:19
@sallyom sallyom force-pushed the cert-recovery-1-yr branch from ee60550 to 9a4c42a Compare January 28, 2021 02:35
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2021

@sallyom: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/periodic-ci-openshift-release-master-ocp-4.5-e2e-gcp-libvirt-cert-rotation 968378c29b7de4b17e9361fa9c9814a1276c6bba link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ocp-4.6-e2e-gcp-libvirt-cert-rotation 9a4c42a link /test pj-rehearse
ci/prow/pj-rehearse 9a4c42a link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2021
@petr-muller
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, sallyom, soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2021
@openshift-merge-robot openshift-merge-robot merged commit 891aaa7 into openshift:master Jan 28, 2021
@openshift-ci-robot
Copy link
Contributor

@sallyom: Updated the following 5 configmaps:

  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/OWNERS
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/conf/OWNERS
    • key openshift-e2e-gcp-libvirt-cert-rotation-conf-commands.sh using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/conf/openshift-e2e-gcp-libvirt-cert-rotation-conf-commands.sh
    • key openshift-e2e-gcp-libvirt-cert-rotation-conf-ref.metadata.json using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/conf/openshift-e2e-gcp-libvirt-cert-rotation-conf-ref.metadata.json
    • key openshift-e2e-gcp-libvirt-cert-rotation-conf-ref.yaml using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/conf/openshift-e2e-gcp-libvirt-cert-rotation-conf-ref.yaml
    • key openshift-e2e-gcp-libvirt-cert-rotation-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/openshift-e2e-gcp-libvirt-cert-rotation-workflow.metadata.json
    • key openshift-e2e-gcp-libvirt-cert-rotation-workflow.yaml using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/openshift-e2e-gcp-libvirt-cert-rotation-workflow.yaml
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/setup/OWNERS
    • key openshift-e2e-gcp-libvirt-cert-rotation-setup-commands.sh using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/setup/openshift-e2e-gcp-libvirt-cert-rotation-setup-commands.sh
    • key openshift-e2e-gcp-libvirt-cert-rotation-setup-ref.metadata.json using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/setup/openshift-e2e-gcp-libvirt-cert-rotation-setup-ref.metadata.json
    • key openshift-e2e-gcp-libvirt-cert-rotation-setup-ref.yaml using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/setup/openshift-e2e-gcp-libvirt-cert-rotation-setup-ref.yaml
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/test/OWNERS
    • key openshift-e2e-gcp-libvirt-cert-rotation-test-commands.sh using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/test/openshift-e2e-gcp-libvirt-cert-rotation-test-commands.sh
    • key openshift-e2e-gcp-libvirt-cert-rotation-test-ref.metadata.json using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/test/openshift-e2e-gcp-libvirt-cert-rotation-test-ref.metadata.json
    • key openshift-e2e-gcp-libvirt-cert-rotation-test-ref.yaml using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/test/openshift-e2e-gcp-libvirt-cert-rotation-test-ref.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/OWNERS
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/conf/OWNERS
    • key openshift-e2e-gcp-libvirt-cert-rotation-conf-commands.sh using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/conf/openshift-e2e-gcp-libvirt-cert-rotation-conf-commands.sh
    • key openshift-e2e-gcp-libvirt-cert-rotation-conf-ref.metadata.json using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/conf/openshift-e2e-gcp-libvirt-cert-rotation-conf-ref.metadata.json
    • key openshift-e2e-gcp-libvirt-cert-rotation-conf-ref.yaml using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/conf/openshift-e2e-gcp-libvirt-cert-rotation-conf-ref.yaml
    • key openshift-e2e-gcp-libvirt-cert-rotation-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/openshift-e2e-gcp-libvirt-cert-rotation-workflow.metadata.json
    • key openshift-e2e-gcp-libvirt-cert-rotation-workflow.yaml using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/openshift-e2e-gcp-libvirt-cert-rotation-workflow.yaml
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/setup/OWNERS
    • key openshift-e2e-gcp-libvirt-cert-rotation-setup-commands.sh using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/setup/openshift-e2e-gcp-libvirt-cert-rotation-setup-commands.sh
    • key openshift-e2e-gcp-libvirt-cert-rotation-setup-ref.metadata.json using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/setup/openshift-e2e-gcp-libvirt-cert-rotation-setup-ref.metadata.json
    • key openshift-e2e-gcp-libvirt-cert-rotation-setup-ref.yaml using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/setup/openshift-e2e-gcp-libvirt-cert-rotation-setup-ref.yaml
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/test/OWNERS
    • key openshift-e2e-gcp-libvirt-cert-rotation-test-commands.sh using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/test/openshift-e2e-gcp-libvirt-cert-rotation-test-commands.sh
    • key openshift-e2e-gcp-libvirt-cert-rotation-test-ref.metadata.json using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/test/openshift-e2e-gcp-libvirt-cert-rotation-test-ref.metadata.json
    • key openshift-e2e-gcp-libvirt-cert-rotation-test-ref.yaml using file ci-operator/step-registry/openshift/e2e/gcp/libvirt/cert-rotation/test/openshift-e2e-gcp-libvirt-cert-rotation-test-ref.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master__ocp-4.6.yaml using file ci-operator/config/openshift/release/openshift-release-master__ocp-4.6.yaml
    • key openshift-release-master__ocp-4.7.yaml using file ci-operator/config/openshift/release/openshift-release-master__ocp-4.7.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-release-master-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-periodics.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-periodics.yaml
Details

In response to this:

This periodic test starts a nested libvirt (3 control plane nodes, 2 compute nodes) cluster in a gcp instance and:

  • stop / start crio & kubelet in each node
  • sets date of each node ahead
  • set date of gcp host ahead
  • approves all certificate-signing-requests
  • waits for:
    • all nodes Ready
    • no pending pods
    • all ClusterOperators are Available=True, Pending=False, Degraded=False

should fail until: openshift/cluster-kube-scheduler-operator#288

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants